Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectl… #5965

Conversation

tkobayas
Copy link
Contributor

Copy link
Contributor

@yurloc yurloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unintentional line, otherwise LGTM.

…l/parser/antlr4/MiscDRLParserTest.java

Co-authored-by: Jiří Locker <[email protected]>
@tkobayas
Copy link
Contributor Author

@mariofusco @gitgabrio Please review, thanks!

@mariofusco mariofusco merged commit 7f338a3 into apache:dev-new-parser May 22, 2024
0 of 3 checks passed
tkobayas added a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
apache#5965)

* [incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectly if init and action statements are empty

* Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java

Co-authored-by: Jiří Locker <[email protected]>

---------

Co-authored-by: Jiří Locker <[email protected]>
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 2, 2024
apache#5965)

* [incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectly if init and action statements are empty

* Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java

Co-authored-by: Jiří Locker <[email protected]>

---------

Co-authored-by: Jiří Locker <[email protected]>
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 11, 2024
apache#5965)

* [incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectly if init and action statements are empty

* Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java

Co-authored-by: Jiří Locker <[email protected]>

---------

Co-authored-by: Jiří Locker <[email protected]>
tkobayas added a commit that referenced this pull request Oct 11, 2024
#5965)

* [incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectly if init and action statements are empty

* Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java

Co-authored-by: Jiří Locker <[email protected]>

---------

Co-authored-by: Jiří Locker <[email protected]>
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
apache#5965)

* [incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectly if init and action statements are empty

* Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java

Co-authored-by: Jiří Locker <[email protected]>

---------

Co-authored-by: Jiří Locker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants