[NO-ISSUE] Use apache-release profile when doing a release build #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstastny-cz
requested changes
May 23, 2024
.ci/jenkins/Jenkinsfile.deploy
Outdated
| .withOptions(env.BUILD_MVN_OPTS_CURRENT ? [ env.BUILD_MVN_OPTS_CURRENT ] : []) | ||
| .withProperty('maven.test.failure.ignore', true) | ||
| .skipTests(params.SKIP_TESTS) | ||
| .withSettingsXmlFile(MAVEN_SETTINGS_FILE) |
There was a problem hiding this comment.
this needs to be in configFileProvider section for MAVEN_SETTINGS_FILE to exist (it's tmp scoped to the defining configFileProvider block).
I'd say extend the configFileProvider block above the def mavenCommand.
There was a problem hiding this comment.
Or move mavenCommand.withSettingsXmlFile into the configFileProvider + run section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gpg setup and apache-release Maven profile to the release build.
Similar (can be merged separately) PRs: