[incubator-kie-drools-5982] [new-parser] Enable alternative attribute… #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Jun 5, 2024
| | name='timer' ( DECIMAL_LITERAL | LPAREN chunk RPAREN ) #intOrChunkAttribute | ||
| | name='duration' ( DECIMAL_LITERAL | LPAREN chunk RPAREN ) #intOrChunkAttribute | ||
| // attributes := (ATTRIBUTES COLON?)? [ attribute ( COMMA? attribute )* ] | ||
| attributes : (DRL_ATTRIBUTES COLON?)? attribute ( COMMA? attribute )* ; |
There was a problem hiding this comment.
This PR just allows attributes: label before attributes
rule simple_rule
attributes:
salience 42, agenda-group "my_group", no-loop, lock-on-active, duration 42, activation-group "my_activation_group"
when
|
@yurloc @mariofusco @gitgabrio Please review, thanks! |
mariofusco
approved these changes
Jun 6, 2024
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Jun 11, 2024
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 2, 2024
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 11, 2024
tkobayas
added a commit
that referenced
this pull request
Oct 11, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s test
Issue: