Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools-5982] [new-parser] Enable alternative attribute… #5983

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Jun 4, 2024

| name='timer' ( DECIMAL_LITERAL | LPAREN chunk RPAREN ) #intOrChunkAttribute
| name='duration' ( DECIMAL_LITERAL | LPAREN chunk RPAREN ) #intOrChunkAttribute
// attributes := (ATTRIBUTES COLON?)? [ attribute ( COMMA? attribute )* ]
attributes : (DRL_ATTRIBUTES COLON?)? attribute ( COMMA? attribute )* ;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR just allows attributes: label before attributes

rule simple_rule
    attributes:
        salience 42, agenda-group "my_group", no-loop,  lock-on-active, duration 42, activation-group "my_activation_group"
    when

@tkobayas
Copy link
Contributor Author

tkobayas commented Jun 5, 2024

@yurloc @mariofusco @gitgabrio Please review, thanks!

@mariofusco mariofusco merged commit d03d1d8 into apache:dev-new-parser Jun 7, 2024
0 of 4 checks passed
tkobayas added a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants