[KIE-1339] fix Drools reproducible build also when running the complete test-suite #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariofusco
commented
Jun 20, 2024
| @AfterClass | ||
| public static void cleanup() { | ||
| try { | ||
| new File(KEYSTORE_JCEKS_FILENAME).delete(); |
There was a problem hiding this comment.
This file is created when this test runs, so it has to be deleted in order to avoid that it mistakenly ends up in the test jar.
mariofusco
commented
Jun 20, 2024
| if (!targetFolder.exists()) { | ||
| throw new RuntimeException("The target folder does not exist, please build project " + exampleName + " first"); | ||
| } | ||
|
|
||
| for (String str : targetFolder.list()) { | ||
| if (str.startsWith(exampleName) && !str.endsWith("-sources.jar") && !str.endsWith("-tests.jar") && !str.endsWith("-javadoc.jar")) { | ||
| if (str.startsWith(exampleName) && str.endsWith(".jar") && !str.endsWith("-sources.jar") && !str.endsWith("-tests.jar") && !str.endsWith("-javadoc.jar")) { |
There was a problem hiding this comment.
This and all subsequent fixes are all identical: the maven task checking the reproducible build adds more files to the target folder, so they have to be filtered away here in order to pick up the correct jar file to be used here.
lucamolteni
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.