[incubator-kie-issues#1326] Filter, Some and Every expression should fail when the matching function doesn't return a Boolean
#6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldimir
approved these changes
Jun 24, 2024
gitgabrio
approved these changes
Jun 24, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jul 8, 2024
…hould fail when the matching function doesn't return a Boolean (apache#6000) * Fix + Tests * Fix tests * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#1326
filter expressionMUST resolve to a Booleanfilter expressionand on the first evaluation a number is returned, we are using an index instead of a boolean filter.That is because in contrast with the previous point AND not described in the specs
matching expressionMUST resolve to a Booleanmatching expressionpart MUST resolve to a Boolean