[incubator-kie-issues#1344] Refactoring/reorganizing Functions #6005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitgabrio
changed the title
yesamer
reviewed
Jun 27, 2024
|
|
||
| import java.math.BigDecimal; | ||
| import java.math.RoundingMode; | ||
|
|
||
| import org.kie.dmn.api.feel.runtime.events.FEELEvent.Severity; | ||
| import org.kie.dmn.feel.runtime.events.InvalidParametersEvent; | ||
| import org.kie.dmn.feel.runtime.functions.BaseFEELFunction; | ||
| import org.kie.dmn.feel.runtime.functions.FEELFnResult; | ||
| import org.kie.dmn.feel.runtime.functions.ParameterName; | ||
|
|
||
| /** | ||
| * provisional access for DMN14-126 |
There was a problem hiding this comment.
@gitgabrio Probably those kind of comment could be removed.
...kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/visitor/ASTTemporalConstantVisitor.java
Show resolved
Hide resolved
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/DurationFunction.java
Show resolved
Hide resolved
...dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/extended/DateFunction.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| public FEELFnResult<TemporalAccessor> manageDateTimeException(DateTimeException e, String val) { |
There was a problem hiding this comment.
@gitgabrio As this is no a method to be consumed externally, I would set is as protected, WDTY?
baldimir
approved these changes
Jun 28, 2024
added 3 commits
June 28, 2024 10:36
…1344 # Conflicts: # kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/functions/ContextFunctionTest.java
…are singleton by design
yesamer
reviewed
Jul 1, 2024
| * | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> |
There was a problem hiding this comment.
@gitgabrio Please check those Test classes, it seems to me they have unintended formatting changes (in the headers and in the below test functions)
| * | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> |
There was a problem hiding this comment.
@gitgabrio This class has unintended formatting changes, I guess
yesamer
approved these changes
Jul 1, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jul 8, 2024
…e#6005) * [incubator-kie-issues#1344] Rrefactoring/reorganizing Functions * [incubator-kie-issues#1344] Fixed as per PR suggestion * [incubator-kie-issues#1344] Hiding constructors from functions, that are singleton by design * [incubator-kie-issues#1344] Fixing tests --------- Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#1344
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.