[incubator-kie-drools-6010] Date Between Dates with globals Not Trigg… #6011
+134
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ering for Executable Model
tkobayas
commented
Jul 5, 2024
Comment on lines
+135
to
+137
| if (!(this.identifier.equals(other.identifier))) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Without this check, ConstraintEvaluator.replaceDeclaration considers that GlobalExtractor for $startDate and GlobalExtractor for $endDate are the same.
tkobayas
commented
Jul 8, 2024
| } | ||
|
|
||
| @Test | ||
| public void dateBetweenVariables() throws ParseException { |
There was a problem hiding this comment.
This test (not using globals) doesn't have the issue, because resolver.getDeclaration() returns the same Declaration object, so replaceDeclaration() is not called.
private void replaceDeclarations( DeclarationScopeResolver resolver, Pattern pattern, Constraint constraint ) {
Declaration[] decl = constraint.getRequiredDeclarations();
for ( Declaration aDecl : decl ) {
Declaration resolved = resolver.getDeclaration( aDecl.getIdentifier() );
if ( constraint instanceof IndexableConstraint && ( (IndexableConstraint) constraint ).isUnification() ) {
if ( ClassObjectType.DroolsQuery_ObjectType.isAssignableFrom( resolved.getPattern().getObjectType() ) ) {
Declaration redeclaredDeclr = new Declaration( resolved.getIdentifier(), ( (IndexableConstraint) constraint ).getFieldExtractor(), pattern, false );
pattern.addDeclaration( redeclaredDeclr );
} else if ( resolved.getPattern() != pattern ) {
( (IndexableConstraint ) constraint ).unsetUnification();
}
}
if ( resolved != null && resolved != aDecl && resolved.getPattern() != pattern ) {
constraint.replaceDeclaration( aDecl,
resolved );
} else if ( resolved == null ) {
|
GHA kogito-apps : not related to this PR GHA kogito-quarkus-examples : not related to this PR |
|
@mariofusco @lucamolteni @pibizza Please review, thanks! |
lucamolteni
approved these changes
Jul 8, 2024
mariofusco
approved these changes
Jul 8, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Jul 8, 2024
…ering for Executable Model (apache#6011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ering for Executable Model
Issue: