[Incubator-kie-issues#1345] It shouldn't be possible to add\subtract a DateTime with a number #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesamer
reviewed
Aug 1, 2024
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/FEEL12ExtendedForLoopTest.java
Outdated
Show resolved
Hide resolved
| @@ -51,6 +51,8 @@ protected void instanceTest(String expression, Object result, FEELEvent.Severity | |||
| private static Collection<Object[]> data() { | |||
| final Object[][] cases = new Object[][] { | |||
| // date/time/duration function invocations | |||
| { "@\"2021-01-01\" + 10", null , FEELEvent.Severity.ERROR}, | |||
| { "@\"2021-01-01T10:10:10\" + 10", null , FEELEvent.Severity.ERROR}, | |||
There was a problem hiding this comment.
@bncriju Can you please add here those additional test cases:
- number + Date
- number + DateTime
- number - Date
- number - DateTime
- Date - number
- DateTime - number
They should all return null with an error.
Just for the sake of completeness :)
Thank you
There was a problem hiding this comment.
@bncriju Don't forget this please :)
gitgabrio
requested changes
Aug 1, 2024
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/FEEL12ExtendedForLoopTest.java
Outdated
Show resolved
Hide resolved
yesamer
approved these changes
Aug 5, 2024
gitgabrio
approved these changes
Aug 5, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Aug 6, 2024
…a DateTime with a number (apache#6040) * Removed the addition of temporal with number and added test cases * removed unused import * replaced null object with list of null
rodrigonull
pushed a commit
to rodrigonull/incubator-kie-drools
that referenced
this pull request
Oct 7, 2024
…a DateTime with a number (apache#6040) * Removed the addition of temporal with number and added test cases * removed unused import * replaced null object with list of null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#1345
It was possible to add a number with a Temporal and was returning the result, which was not right. According to DMN specification, addition of Temporal with a number shouldn't be supported. This PR has the changes to bring the behavior supported by DMN spec.