[10.0.x] NO-ISSUE: Use default maven settings file for release #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LightGuard
approved these changes
Aug 14, 2024
porcelli
approved these changes
Aug 14, 2024
jstastny-cz
reviewed
Aug 15, 2024
| configFileProvider([configFile(fileId: env.MAVEN_SETTINGS_CONFIG_FILE_ID, variable: 'MAVEN_SETTINGS_FILE')]) { | ||
| mavenCommand.withSettingsXmlFile(MAVEN_SETTINGS_FILE).run("clean $installOrDeploy") | ||
| mavenCommand.withSettingsXmlFile(MAVEN_SETTINGS_FILE) |
There was a problem hiding this comment.
This won't ever use this config file, because its existence is bound to the surrounding configFileProvider - thus this ends up with -s pointing at non-existent file at the time of mavenCommand.run .... I assume nightly is broken by this.
There was a problem hiding this comment.
Ok, nightly uses different jenkinsfile, though IMHO still is not valid.
rodrigonull
added a commit
that referenced
this pull request
Aug 15, 2024
This reverts commit 1320d83.
rodrigonull
added a commit
that referenced
this pull request
Aug 15, 2024
rodrigonull
added a commit
to rodrigonull/incubator-kie-drools
that referenced
this pull request
Sep 17, 2024
rodrigonull
added a commit
to rodrigonull/incubator-kie-drools
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modify the build to use the default .m2/settings.xml file for the release.