Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1411] Adapt DMN code to deal with full href definition (namespace#local_part) for local elements. #6050

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Aug 19, 2024

Fixes apache/incubator-kie-issues#1411

@bncriju

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

…nition (namespace#local_part) for local elements.
Copy link
Contributor

@bncriju bncriju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@gitgabrio gitgabrio requested review from jomarko and removed request for yesamer August 20, 2024 07:49
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gitgabrio . I have just a single comment. Not sure about http://www.montera.com usage. I know currently it is not used by any company, but that may change in future I guess? Maybe more safe would be to use more demo-ish?

  • http://www.mycompany.com
  • http://www.dmntestcompany.com
  • http://www.example.com

@gitgabrio
Copy link
Contributor Author

Thank you @gitgabrio . I have just a single comment. Not sure about http://www.montera.com usage. I know currently it is not used by any company, but that may change in future I guess? Maybe more safe would be to use more demo-ish?

* `http://www.mycompany.com`

* `http://www.dmntestcompany.com`

* `http://www.example.com`

Hi @jomarko
Those are the names used in the TCK, and I took them as they are. We may consider to replace them in future, but I would prefer to merge this PR now. THanks again!

@gitgabrio gitgabrio merged commit 3dac669 into apache:main Aug 20, 2024
10 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1411 branch August 20, 2024 09:00
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Aug 26, 2024
…nition (namespace#local_part) for local elements. (apache#6050)

Co-authored-by: Gabriele-Cardosi <[email protected]>
rodrigonull pushed a commit to rodrigonull/incubator-kie-drools that referenced this pull request Oct 7, 2024
…nition (namespace#local_part) for local elements. (apache#6050)

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not possible to refer to an external nodes in informationRequirement and knowledgeRequirement
4 participants