-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1409]-Fixed matches function behavior #6055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @bncriju great job!!!
@@ -18,16 +18,21 @@ | |||
*/ | |||
package org.kie.dmn.feel.runtime.functions; | |||
|
|||
import java.security.InvalidParameterException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bncriju is this import used / correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesamer Whenever input/pattern is null, this is the most appropriate one to be used. it seems. This is used to catch this condition and whenever we verify this case in test as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bncriju My point is: that expection is part of the java.security
package. That means it should be used in the security management scope (as described here https://docs.oracle.com/javase/8/docs/api/java/security/InvalidParameterException.html).
In our context, IllegalArgumentException should be used
@bncriju I run your changes against the TCK tests, and cases 5. and 6. are still not working. Is that intended? |
Fixes apache/incubator-kie-issues#1409
for pull request and downstream checks
for a full downstream build
run_fdb
for Jenkins PR check only
Build Now
button.