Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1409]-Fixed matches function behavior #6055

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

bncriju
Copy link
Contributor

@bncriju bncriju commented Aug 22, 2024

Fixes apache/incubator-kie-issues#1409

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @bncriju great job!!!

@@ -18,16 +18,21 @@
*/
package org.kie.dmn.feel.runtime.functions;

import java.security.InvalidParameterException;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bncriju is this import used / correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesamer Whenever input/pattern is null, this is the most appropriate one to be used. it seems. This is used to catch this condition and whenever we verify this case in test as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bncriju My point is: that expection is part of the java.security package. That means it should be used in the security management scope (as described here https://docs.oracle.com/javase/8/docs/api/java/security/InvalidParameterException.html).
In our context, IllegalArgumentException should be used

@baldimir baldimir merged commit edc77d5 into apache:main Aug 23, 2024
10 checks passed
@yesamer
Copy link
Contributor

yesamer commented Aug 26, 2024

@bncriju I run your changes against the TCK tests, and cases 5. and 6. are still not working. Is that intended?

rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Aug 26, 2024
@bncriju bncriju deleted the kie-issues#1409 branch September 3, 2024 13:48
rodrigonull pushed a commit to rodrigonull/incubator-kie-drools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matches() function wrongly behaves - checks and unicode
4 participants