Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO ISSUE: Replaces junit assertions with assertj assertions in kie-dmn-openapi #6057

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

pibizza
Copy link
Contributor

@pibizza pibizza commented Aug 29, 2024

Cleanup to remove junit assertions and use instead assertj assertions in kie-dmn-openapi.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@pibizza
Copy link
Contributor Author

pibizza commented Aug 29, 2024

Failure on windows is unrelated.

2024-08-29T09:10:25.6040872Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-npm (install node and npm) on project drools-docs: Could not download Node.js from: https://nodejs.org/dist/v16.2.0/win-x64/node.exe: Could not download https://nodejs.org/dist/v16.2.0/win-x64/node.exe

@pibizza pibizza merged commit 2fcc0e5 into apache:main Sep 3, 2024
9 of 10 checks passed
@pibizza pibizza deleted the assert-clean branch September 3, 2024 12:43
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Sep 5, 2024
rodrigonull pushed a commit to rodrigonull/incubator-kie-drools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants