[incubator-kie-drools-5745] Compatibility issue with Spring-boot 3.2 #6064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
commented
Sep 4, 2024
Comment on lines
+33
to
+43
| @Test | ||
| public void replaceNestedPathForSpringBoot32_shouldNotAffectOldPath() { | ||
| String result = JarUtils.replaceNestedPathForSpringBoot32("/dir/myapp.jar!/BOOT-INF/lib/mykjar.jar"); | ||
| assertThat(result).isEqualTo("/dir/myapp.jar!/BOOT-INF/lib/mykjar.jar"); | ||
| } | ||
|
|
||
| @Test | ||
| public void replaceNestedPathForSpringBoot32_shouldReplaceNewPath() { | ||
| String result = JarUtils.replaceNestedPathForSpringBoot32("/dir/myapp.jar/!BOOT-INF/lib/mykjar.jar"); | ||
| assertThat(result).isEqualTo("/dir/myapp.jar!/BOOT-INF/lib/mykjar.jar"); | ||
| } |
There was a problem hiding this comment.
Added simple unit tests only.
I have manually tested with spring boot 3.2.6 uber jar. https://github.com/tkobayas/kiegroup-examples/tree/master/Ex-spring-boot-3.2-demo-main . and confirmed that the issue is solved.
Adding such integration tests (actually build a uber jar and run it with ProcessBuilder) might be worth discussing.
mariofusco
approved these changes
Sep 4, 2024
pibizza
changed the title
pibizza
approved these changes
Sep 6, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Sep 9, 2024
rodrigonull
pushed a commit
to rodrigonull/incubator-kie-drools
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: