Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky behavior in creating MethodCallExpr and Consequence #6073

Closed
wants to merge 1 commit into from
Closed

Fix flaky behavior in creating MethodCallExpr and Consequence #6073

wants to merge 1 commit into from

Commits on Sep 9, 2024

  1. Fix flaky test in AccumulateTest#testInlineAccumulateWithAnd by using… 

    … TreeSet to ensure order consistency

- Changed extractUsedDeclarations method to use TreeSet instead of Set to guarantee a consistent order of declarations.
- This resolves the flaky behavior encountered when running with NonDex, which caused Drools to fail compiling the Java file.
- The issue stemmed from the fact that the original Set did not maintain order, which is crucial when the order of arguments is important in rule compilation.

Signed-off-by: Yusen Wang <[email protected]>
    @everbrightw
    everbrightw committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    effc20d View commit details
    Browse the repository at this point in the history