[DROOLS-7631] unify coercion checks between plain drl and executable model #6086
Conversation
| return new CoercedExpressionResult(coercedLeft, coercedRight, rightAsStaticField); | ||
| } | ||
|
|
||
| private void checkCoercion(TypedExpression coercedLeft, TypedExpression coercedRight, Class<?> leftClass, Class<?> rightClass) { | ||
| if (equalityExpr) { |
There was a problem hiding this comment.
Since this is known at creation time you can inline the check and put instead a lambda inside the expression? so you would not repeat the check for every invocation of the cohercion.
There was a problem hiding this comment.
I believe that this will reduce a bit the readability, and if you are suggesting this only for performance reason I'm pretty sure that invoking a bimorphic capturing lambda will be order of magnitude slower than accessing a local boolean variable.
There was a problem hiding this comment.
Performance wise I am ignorant and you are probably right. My point is that if something that affects the behavious of an object is known at creation time of an object you should make the object behave accordingly. But I admit it that this is a minor point and we can keep it as it is. thank you.
Fix for https://issues.redhat.com/browse/DROOLS-7631
The plain drl compilation already reports the compile time error
Error: Comparison operation requires compatible types. Found class java.time.LocalDateTime and class java.util.Datebut this doesn't happen when generating the executable model than then fails at runtime with the
ClassCastExceptionreported in that jira.The purpose of this pull request is reusing the same code for coercion checks for both plain drl compilation and executable model generation.