-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… #6096
[incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… #6096
Conversation
…ontests.TimerAndCalendarFireUntilHaltTest
2aabeee
to
4f44b28
Compare
Draft PR to be used for investigation: #6095 |
activateRule(); | ||
advanceTimerOneSecond(); | ||
|
||
await().until(ruleHasFired("TimerRule", 1)); | ||
|
||
advanceTimerOneSecond(); | ||
await().until(ruleHasFired("TimerRule", 2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flakiness was that fireUntilHalt
may or may not fire a match between activateRule()
and advanceTimerOneSecond()
. Usually, it doesn't fire, so the assertion worked with ruleHasFired("TimerRule", 1)
. However, to be stable, the test has to wait the first firing before advanceTimerOneSecond()
. So the subsequent assertions are changed accordingly.
advanceTimerOneSecond(); | ||
await().until(ruleHasFired("TimerRule", 2)); | ||
|
||
stopEngine(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stopEngine
is not related to the issue. But make sure to clean up.
…ontests.TimerAndCalendarFireUntilHaltTest (apache#6096)
…ontests.TimerAndCalendarFireUntilHaltTest (apache#6096)
…ontests.TimerAndCalendarFireUntilHaltTest
Issue: