[incubator-kie-drools-6093] flaky test: org.drools.compiler.integrati… #6096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontests.TimerAndCalendarFireUntilHaltTest
tkobayas
force-pushed
the
incubator-kie-drools-6093-flaky-TimerAndCalendarFireUntilHaltTest-fix
branch
from
2aabeee
to
4f44b28
Compare
|
Draft PR to be used for investigation: #6095 |
tkobayas
commented
Sep 20, 2024
Comment on lines
111
to
+115
| activateRule(); | ||
| advanceTimerOneSecond(); | ||
|
|
||
| await().until(ruleHasFired("TimerRule", 1)); | ||
|
|
||
| advanceTimerOneSecond(); | ||
| await().until(ruleHasFired("TimerRule", 2)); |
There was a problem hiding this comment.
The flakiness was that fireUntilHalt may or may not fire a match between activateRule() and advanceTimerOneSecond(). Usually, it doesn't fire, so the assertion worked with ruleHasFired("TimerRule", 1). However, to be stable, the test has to wait the first firing before advanceTimerOneSecond(). So the subsequent assertions are changed accordingly.
tkobayas
commented
Sep 20, 2024
| advanceTimerOneSecond(); | ||
| await().until(ruleHasFired("TimerRule", 2)); | ||
|
|
||
| stopEngine(); |
There was a problem hiding this comment.
This stopEngine is not related to the issue. But make sure to clean up.
mariofusco
approved these changes
Sep 23, 2024
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Sep 25, 2024
…ontests.TimerAndCalendarFireUntilHaltTest (apache#6096)
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Oct 3, 2024
…ontests.TimerAndCalendarFireUntilHaltTest (apache#6096)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ontests.TimerAndCalendarFireUntilHaltTest
Issue: