Cache compiled dtables during the building of a KieProject #6097
Conversation
| } | ||
|
|
||
| private static void clearBuilderCache() { | ||
| DecisionTableFactory.clearCompilerCache(); |
There was a problem hiding this comment.
In general I believe that there could be other things that we may want to cache when building a KieProject, so we could eventually perform the clean up of all those caches here.
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6097 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6097/1/display/redirect Test results:
Those are the test failures: org.drools.decisiontable.SpreadsheetIntegrationExampleTest.testHeadingWhitespaceExpecting actual not to be null org.drools.decisiontable.SpreadsheetIntegrationExampleTest.testNamedWorksheetExpected size: 1 but was: 0 in: [] org.drools.decisiontable.project.MultiSheetsTest.testSheet12Unable to create KieModule, Errors Existed: [Message [id=1, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=5, column=0text=Duplicate rule name: ID change_11], Message [id=2, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=13, column=0 text=Duplicate rule name: ID change_12], Message [id=3, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=13, column=0 text=Rule Compilation error The type Rule_ID_change_12178611955 is already defined], Message [id=4, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=5, column=0 text=Rule Compilation error The type Rule_ID_change_111481680058 is already defined]] org.drools.decisiontable.project.MultiSheetsTest.testSheet2Expecting actual: "[Mario can drink]" to contain: "Mario can drive" org.drools.compiler.integrationtests.MultiSheetsTest.testSheet12[KieBase type=CLOUD_IDENTITY]Unable to create KieModule, Errors Existed: [Message [id=1, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=5, column=0text=Duplicate rule name: ID change_11], Message [id=2, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=13, column=0 text=Duplicate rule name: ID change_12], Message [id=3, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=13, column=0 text=Rule Compilation error The type Rule_ID_change_12178611955 is already defined], Message [id=4, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=5, column=0 text=Rule Compilation error The type Rule_ID_change_111481680058 is already defined]] org.drools.compiler.integrationtests.MultiSheetsTest.testSheet2[KieBase type=CLOUD_IDENTITY]Expecting value to be true but was false expected:<[tru]e> but was:<[fals]e> org.drools.compiler.integrationtests.MultiSheetsTest.testSheet12[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]Unable to create KieModule, Errors Existed: [Message [id=1, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=5, column=0text=Duplicate rule name: ID change_11], Message [id=2, kieBase=dtblaleKB, level=ERROR, path=org/drools/simple/candrink/CanDrink.drl.xls, line=13, column=0 text=Duplicate rule name: ID change_12]] org.drools.compiler.integrationtests.MultiSheetsTest.testSheet2[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]Expecting value to be true but was false expected:<[tru]e> but was:<[fals]e> org.drools.compiler.integrationtests.incrementalcompilation.IncrementalCompilationTest.testDecisionTable[KieBase type=CLOUD_IDENTITY]Cannot find KieModule: org.kie:test-dtable:1.1.1org.drools.compiler.integrationtests.incrementalcompilation.IncrementalCompilationTest.testDecisionTable[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN]Cannot find KieModule: org.kie:test-dtable:1.1.1 |
| private static final transient Logger logger = LoggerFactory.getLogger( DecisionTableProviderImpl.class ); | ||
| private static final Logger logger = LoggerFactory.getLogger( DecisionTableProviderImpl.class ); | ||
|
|
||
| private Map<String, String> compiledDtablesCache = new HashMap<>(); |
There was a problem hiding this comment.
Thank you, @mariofusco . Shouldn't this be ConcurrentHashMap because DecisionTableProviderImpl is a singleton in DecisionTableFactory?
There was a problem hiding this comment.
I guess you're right. In reality I was thinking to it yesterday when I wrote that code, and I decided that we don't have any situation when we do 2 dtable -> drl conversions in parallel, but I was not properly considering that this is a singleton indeed. Better to play on the safe side on this. I will turn it into a ConcurrentHashMap, thanks.
Fixes #6088 and provide an alternative solution to what implemented in #6089.
I believe this is a better solution for a twofold reason: