Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO ISSUE: Migrate tests in drools traits to JUnit5. #6122

Merged
merged 13 commits into from
Oct 11, 2024

Conversation

pibizza
Copy link
Contributor

@pibizza pibizza commented Oct 10, 2024

This patch is intended to:

  • migrate unit tests in drools traits to JUnit5
  • cleanup assertions in drools traits.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@pibizza pibizza requested review from mariofusco, gitgabrio and tkobayas and removed request for mariofusco October 10, 2024 14:57
@pibizza pibizza merged commit 23fa0a3 into apache:main Oct 11, 2024
8 of 9 checks passed
@pibizza pibizza deleted the assertj-traits-cleanup branch October 11, 2024 07:04
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
* First steps

* More small cleanups

* More cleanups...

* More cleanups...

* More cleanups...

* More cleanups...

* More cleanups, progressing

* Fixed size assertions

* Fixed instanceof in tests

* Fixed equals in assertj

* Cleaned up isTrue assertions

* Proper use of assertions on exceptions

* Removed last bits of JUnit5 from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants