-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues#1528] Implement DMNEvent reporting inside DMNConditionalEvaluator. #6124
Conversation
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6124 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6124/1/display/redirect Test results:
Those are the test failures: org.kie.dmn.validation.ValidatorTest.validateAllValidSharedModelsExpecting empty but was: [Message [id=0, level=WARNING, path=valid_models/DMNv1_5/RiskScore_Simple.dmn, line=46, column=-1 text=DMN: Decision table with single output on node 'Risk Score' should not have output name (DMN id: _8694B6C1-E07D-49A0-B77B-B8BF99C85B1D, The referenced element should not have a name set) ]] |
kogito-runtimes failure unrelated
serverless-workflow-examples failure unrelated |
…nditionalEvaluator. (apache#6124) * [incubator-kie-issues#1528] Implement DMNEvent reporting inside DMNConditionalEvaluator. * [incubator-kie-issues#1528] Implement DMNEvent reporting inside DMNConditionalEvaluator. * [incubator-kie-issues#1528] Fix RiskScore_Simple.dmn * [incubator-kie-issues#1528] Fix id used to track conditional evaluation --------- Co-authored-by: Gabriele-Cardosi <[email protected]>
FIxes incubator-kie-issues#1528
Requires
apache/incubator-kie-kogito-runtimes#3727
This PR:
AfterEvaluateConditionalEvent
andAfterConditionalEvaluationEvent
DMNRuntimeEventManagerUtils
DMNConditionalEvaluator
EvaluatorResult
to kie-dmn-apiHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdb
for Jenkins PR check only
Build Now
button.