-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kie-issues 1787] [CVE] [MEDIUM] Update logback version to 1.5.13 #6236
base: main
Are you sure you want to change the base?
Conversation
Thank you @LightGuard ! A PR for this update already exists #6233, can you please get in touch with @RemyaK1 to agree on how to proceed? |
Hi @yesamer @LightGuard you can merge this change. I was looking in to BAMOE 8 CVEs. I got confused between the repo initially and raised the other PR. I have closed that PR with comment and this can be merged. For BAMOE 8 Logback change I have raised the other PR. Sorry for the confusion. |
Hi @LightGuard |
|
It may be that the archetype test is comparing also pom.xml files of the archetype. So if a dependency changes, the version may be different in comparison. Not sure if that is the case though. I retriggered the PR checks. |
@LightGuard It is strange that I see other changes in the diff view than logback. Could you please rebase or update this PR with the latest changes from main? It would be ideal to see only logback upgrade in the diff view, so we are sure we don't overwrite something else. |
Updating logback to 1.5.16 This syncs the version of logback with the rest of KIE Signed-off-by: Jason Porter <[email protected]>
dbd1e37
to
c1e4088
Compare
@baldimir updated, simplified, and still errored, but because things have changed, at least that's what it looked like in the maven output. |
Signed-off-by: Jason Porter <[email protected]>
Well, all green now. |
Updating logback