[KOGITO-9842] The initial load job task from DB is not executed Job Service #1888
Conversation
| @@ -93,6 +93,8 @@ void onStartup(@Observes @Priority(Interceptor.Priority.PLATFORM_AFTER) StartupE | |||
|
|
|||
| protected void onMessagingStatusChange(@Observes MessagingChangeEvent event) { | |||
| this.enabled.set(event.isEnabled()); | |||
| //run load jobs once the instance become a leader to avoid waiting for the next periodic run | |||
| vertx.runOnContext(this::loadJobDetails); | |||
There was a problem hiding this comment.
I believe that by doing this, we might fall in the situation that two loadJobDetails can be executing at the same time, not good.
This is the scenario:
- loadJobDetails_programmed is about to start, let's say in 5 ms
- The events arrive and loadJobDetails_2 is launched
- loadJDetals_programmed starts
- loadJobDetils_programmed and loadJobDetails_2 executes at the same time.
To do this "forced" start with the event we might probably need a synchronized queue to store the loadJobDetails work, or some other mechanism.
There was a problem hiding this comment.
There should be no issue running more than once loadJobDetails, there is a check in the method to avoid scheduling the same job multiple times with a ConcurrentMap. Still, I agree with your point, and this can be improved, let me think a bit and send an update to the PR to improve this process. Thanks for bringing up this point!
There was a problem hiding this comment.
@wmedvede I updated the PR
| schedulerChunkInMinutes, | ||
| schedulerChunkInMinutes); | ||
| loadJobIntervalInMinutes = schedulerChunkInMinutes; | ||
| if (enabled.get()) { |
There was a problem hiding this comment.
if the enabled value can be changed only by the MessagingChangeEvent arrival, and we are already starting the load at this point when needed, I believe we don't need this method any more.
| } | ||
| } | ||
|
|
||
| protected synchronized void onMessagingStatusChange(@Observes MessagingChangeEvent event) { |
There was a problem hiding this comment.
maybe here we can do this:
if (enabled.get() && !wasEnabled) {
// good, avoid starting twice if we receive two consecutive enabled = true
startJobsLoadingFromRepositoryTask();
} else if (!enabled.get()) {
// but only cancel if we receive enabled = false, otherwise with two consecutive enable we are also cancelling.
cancelJobsLoadingFromRepositoryTask();
}
tiagodolphine
force-pushed
the
KOGITO-9842
branch
from
b05d0b4
to
f21dc82
Compare
tiagodolphine
force-pushed
the
KOGITO-9842
branch
from
f21dc82
to
94348e4
Compare
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1888 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1888/8/display/redirect Test results:
Those are the test failures: org.kie.kogito.persistence.oracle.OracleStorageServiceIT.testQuery_EqualError invoking subclass method |
tiagodolphine
force-pushed
the
KOGITO-9842
branch
from
94348e4
to
f6175ec
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ricardozanini looks like we have greens here! I think we should merge |
…ervice (apache#1888) * KOGITO-9842 The initial load job task from DB is not executed Job Service
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject[0.9.x] KOGITO-XYZ SubjectHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
Quarkus-3 PR check is failing ... what to do ?
The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.The first patch, called
0001_before_sh.patch, is generated from Openrewrite.ci/environments/quarkus-3/quarkus3.ymlrecipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.No panic, there is an easy way to regenerate it. You just need to comment on the PR:
and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.