Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #2070] Harnessing TestEventPublisher #2071

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jun 17, 2024

Fix #2070

@@ -0,0 +1 @@
quarkus.devservices.enabled=false
Copy link
Contributor Author

@fjtirado fjtirado Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not really need quarkus dev service to be enable (or at least I believe so, lets see CI)

@fjtirado fjtirado changed the title [Fix #2070] Synchronizing TestEventPublisher [Fix #2070] Harnessing TestEventPublisher Jun 17, 2024
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 waiting for the green

@kie-ci3
Copy link
Contributor

kie-ci3 commented Jun 17, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2071 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2071/2/display/redirect

Test results:

  • PASSED: 1663
  • FAILED: 2

Those are the test failures:

org.kie.kogito.index.ProcessDataIndexInfinispanIT.testProcessInstanceEvents 1 expectation failed.
JSON path errors doesn't match.
Expected: null
Actual: <[{message=Exception while fetching data (/UserTaskInstances[0]/schema) : Runtime service URL not defined, please review the kogito.service.url system property to point the public URL for this runtime., locations=[{line=1, column=85}], path=[UserTaskInstances, 0, schema], extensions={classification=DataFetchingException}}]>
org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents Cannot invoke method size() on null object

@fjtirado
Copy link
Contributor Author

fjtirado commented Jun 17, 2024

@pefernan There are unrelated failures. I propose to merge this one and create an issue for the other two. Wdyt?

@pefernan
Copy link
Contributor

@fjtirado we can go for it!

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @fjtirado for taking care of this.

@fjtirado fjtirado merged commit b78db84 into apache:main Jun 17, 2024
4 of 5 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-apps that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmbeddedJobServiceTest potentially flaky
4 participants