Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Enable rebase and merge button #2080

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

rodrigonull
Copy link
Contributor

@rodrigonull rodrigonull commented Jul 16, 2024

Enables the rebase and merge button.

@rodrigonull rodrigonull changed the title NO-ISSUE: Enable rebase merge button NO-ISSUE: Enable rebase and merge button Jul 16, 2024
@tiagobento tiagobento merged commit 7b54770 into apache:main Jul 16, 2024
4 of 5 checks passed
@kie-ci3
Copy link
Contributor

kie-ci3 commented Jul 16, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2080 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2080/1/display/redirect

Test results:

  • PASSED: 1663
  • FAILED: 2

Those are the test failures:

org.kie.kogito.jobs.service.scheduler.impl.VertxTimerServiceSchedulerTest.testScheduleJob
Unnecessary stubbings detected.
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
1. -> at org.kie.kogito.jobs.service.scheduler.impl.VertxTimerServiceSchedulerTest.testScheduleJob(VertxTimerServiceSchedulerTest.java:98)
Please remove unnecessary stubbings or use 'lenient' strictness. More info: javadoc for UnnecessaryStubbingException class.
org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService java.util.ConcurrentModificationException
at java.base/java.util.ArrayList.forEach(ArrayList.java:1513)
at java.base/java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1092)
at org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService(EmbeddedJobsServiceTest.java:99)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@rodrigonull rodrigonull deleted the enable-rebase-merge branch August 27, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants