Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #2113] Data index group processing #2114

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Oct 14, 2024

Fix #2113

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 14, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2114 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2114/2/display/redirect

Test results:

  • PASSED: 1704
  • FAILED: 2

Those are the test failures:

org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEventCollection Assertion condition defined as a org.kie.kogito.index.service.messaging.AbstractMessagingConsumerIT 1 expectation failed.
JSON path data.ProcessInstances.size() doesn't match.
Expected: is <2>
Actual: <1>
within 30 seconds.
org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEventCollection Assertion condition defined as a org.kie.kogito.index.service.messaging.AbstractMessagingConsumerIT 1 expectation failed.
JSON path data.ProcessInstances.size() doesn't match.
Expected: is <2>
Actual: <1>
within 30 seconds.

Copy link
Contributor

@wmedvede wmedvede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick.
Thanks!

@fjtirado fjtirado force-pushed the Fix_#2113 branch 6 times, most recently from b28fccf to f0b023d Compare October 15, 2024 15:59
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, awesome work @fjtirado !
Just a couple of minor comments

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 15, 2024

PR job #8 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2114 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2114/8/display/redirect

Test results:

  • PASSED: 1704
  • FAILED: 1

Those are the test failures:

org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService java.util.ConcurrentModificationException
at java.base/java.util.ArrayList.forEach(ArrayList.java:1513)
at java.base/java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1092)
at org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService(EmbeddedJobsServiceTest.java:99)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

…c/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java

Co-authored-by: Gonzalo Muñoz <[email protected]>
@fjtirado fjtirado merged commit b733219 into apache:main Oct 16, 2024
5 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-apps that referenced this pull request Oct 24, 2024
* [Fix apache#2113] Data index group processing

* [Fix apache#2113] Support group containing different process instance ids

* [Fix apache#2113] Flush call is probably not needed

* [Fix apache#2113] Optimization for user tasks

* Update data-index/data-index-storage/data-index-storage-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java

Co-authored-by: Gonzalo Muñoz <[email protected]>

---------

Co-authored-by: Gonzalo Muñoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Index processing events in groups
5 participants