-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #2113] Data index group processing #2114
Conversation
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2114 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2114/2/display/redirect Test results:
Those are the test failures: org.kie.kogito.index.service.messaging.PostgreSqlMessagingHttpConsumerIT.testProcessInstanceEventCollectionAssertion condition defined as a org.kie.kogito.index.service.messaging.AbstractMessagingConsumerIT 1 expectation failed.JSON path data.ProcessInstances.size() doesn't match. Expected: is <2> Actual: <1> within 30 seconds. org.kie.kogito.index.service.messaging.PostgreSqlMessagingKafkaConsumerIT.testProcessInstanceEventCollectionAssertion condition defined as a org.kie.kogito.index.service.messaging.AbstractMessagingConsumerIT 1 expectation failed.JSON path data.ProcessInstances.size() doesn't match. Expected: is <2> Actual: <1> within 30 seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick.
Thanks!
data-index/data-index-common/src/main/java/org/kie/kogito/index/service/IndexingService.java
Outdated
Show resolved
Hide resolved
b28fccf
to
f0b023d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, awesome work @fjtirado !
Just a couple of minor comments
...-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java
Outdated
Show resolved
Hide resolved
...-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java
Show resolved
Hide resolved
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2114 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2114/8/display/redirect Test results:
Those are the test failures: org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobServicejava.util.ConcurrentModificationExceptionat java.base/java.util.ArrayList.forEach(ArrayList.java:1513) at java.base/java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1092) at org.kie.kogito.jobs.embedded.EmbeddedJobsServiceTest.testJobService(EmbeddedJobsServiceTest.java:99) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:1013) at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:827) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) |
…c/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java Co-authored-by: Gonzalo Muñoz <[email protected]>
* [Fix apache#2113] Data index group processing * [Fix apache#2113] Support group containing different process instance ids * [Fix apache#2113] Flush call is probably not needed * [Fix apache#2113] Optimization for user tasks * Update data-index/data-index-storage/data-index-storage-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java Co-authored-by: Gonzalo Muñoz <[email protected]> --------- Co-authored-by: Gonzalo Muñoz <[email protected]>
Fix #2113