[incubator-kie-issues#1541] Add “evaluationHitIds” to the response of jitexecutor-dmn’s “/dmnresult” route #2120

gitgabrio · 2024-10-18T10:02:36Z

This PR:

add Set<String> evaluationHitIds field to JITDMNResult
define a specific JITDMNListener that store evaluated ids
add the above listener to DMNRuntime used behind /dmnresult rest endpoint
add the retrieved ids to the returned JITDMNResult

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ?

The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.

The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:

jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.

Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

…_to_input

…evaluationHitIds" field

…1541

yesamer

Thank you @gitgabrio, your changes are fine. Just some autoformatting points

yesamer · 2024-10-21T08:21:51Z

jitexecutor/jitexecutor-dmn/src/main/java/org/kie/kogito/jitexecutor/dmn/JITDMNListener.java

+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>


Suggested change

* <p>

*

yesamer · 2024-10-21T08:22:07Z

jitexecutor/jitexecutor-dmn/src/main/java/org/kie/kogito/jitexecutor/dmn/JITDMNListener.java

+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>


Suggested change

* <p>

*

yesamer · 2024-10-21T08:23:32Z

jitexecutor/jitexecutor-dmn/src/main/java/org/kie/kogito/jitexecutor/dmn/DMNEvaluator.java

@@ -99,7 +110,8 @@ public static DMNEvaluator fromMultiple(MultipleResourcesPayload payload) {
            }
        }
        if (mainModel == null) {
-            throw new IllegalStateException("Was not able to identify main model from MultipleResourcesPayload contents.");
+            throw new IllegalStateException("Was not able to identify main model from MultipleResourcesPayload " +
+                    "contents.");


@gitgabrio autoformatting? :D

jomarko

@gitgabrio I put some comments to code, I didn't checked added tests for now, will do later, probably once we figure out if it is possible to hit single rule multiple times in single evaluation. See the private discussion with @ljmotta

jomarko · 2024-10-21T11:06:43Z

jitexecutor/jitexecutor-dmn/src/main/java/org/kie/kogito/jitexecutor/dmn/DMNEvaluator.java

 import java.util.Map;
+import java.util.Optional;
+import java.util.Set;


this is maybe unused now?

jomarko · 2024-10-21T11:07:11Z

jitexecutor/jitexecutor-dmn/src/main/java/org/kie/kogito/jitexecutor/dmn/DMNEvaluator.java

+                .findFirst()
+                .map(JITDMNListener.class::cast)
+                .map(JITDMNListener::getEvaluationHitIds);
+        return new JITDMNResult(getNamespace(), getName(), dmnResult, evaluationHitIds.orElse(Collections.emptySet()));


emptyList

Thanks for spotting!

kie-ci3 · 2024-10-21T16:10:49Z

PR job #4 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2120 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2120/4/display/redirect

Test results:

PASSED: 1648
FAILED: 2

Those are the test failures:

PR check / Build projects / org.kie.kogito.it.jobs.WorkflowTimeoutsIT.workflowTimeoutExceeded

java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

org.kie.kogito.jobs.service.resource.KeycloakPostgreSqlJobResourceTest.(?)

java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.testcontainers.quarkus.PostgreSqlQuarkusTestResource

This PR is related to: apache/incubator-kie-kogito-apps#2120 where we are adding new unit tests using DMN models from the drools/kie-dmn/kie-dmn-test-resources

- test DMN model where a decision table is nested under conditional expression - test DMN model where collection data type is used as input and output

* kie-issues#1541: Add testing models into kie-dmn-test-resources This PR is related to: apache/incubator-kie-kogito-apps#2120 where we are adding new unit tests using DMN models from the drools/kie-dmn/kie-dmn-test-resources * Collections.dmn -> MultipleHitRules.dmn * Remove <output/> name attribute

kie-issues#1541: Extend test coverage

…1541

jomarko

Thank you @gitgabrio

gitgabrio · 2024-10-23T10:05:57Z

kogito-apps failure unrelated

Failed to execute goal com.google.cloud.tools:jib-maven-plugin:2.8.0:dockerBuild (default) on project integration-tests-trusty-service-springboot: Unknown mediaType: application/vnd.oci.image.index.v1+json

kie-ci3 · 2024-10-23T10:58:14Z

PR job #7 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2120 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2120/7/display/redirect

Test results:

PASSED: 1662
FAILED: 1

Those are the test failures:

org.kie.kogito.explainability.messaging.ExplainabilityMessagingHandlerCounterfactualsIT.explainabilityRequestIsProcessedAndAnIntermediateMessageIsSent

Wanted but not invoked:
explanationServiceImpl.explainAsync(
,

);
-> at org.kie.kogito.explainability.messaging.BaseExplainabilityMessagingHandlerIT.explainabilityRequestIsProcessedAndAnIntermediateMessageIsSent(BaseExplainabilityMessagingHandlerIT.java:140)
Actually, there were zero interactions with this mock.

…1541

kie-ci3 · 2024-10-23T17:20:56Z

PR job #9 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #2120 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-2120/9/display/redirect

Test results:

PASSED: 1677
FAILED: 7

Those are the test failures:

org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlHttpIT.testProcessInstanceEvents

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource

org.kie.kogito.index.postgresql.ProcessDataIndexPostgreSqlKafkaIT.testProcessInstanceEvents

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.kafka.DataIndexPostgreSqlQuarkusKafkaTestResource

org.kie.kogito.index.ProcessDataIndexMongoDBIT.testProcessInstanceEvents

Cannot invoke method size() on null object

org.kie.kogito.index.ProcessDataIndexPostgreSqlIT.testProcessInstanceEvents

Failed to load ApplicationContext for [WebMergedContextConfiguration@50e3019b testClass = org.kie.kogito.index.ProcessDataIndexPostgreSqlIT, locations = [], classes = [org.kie.kogito.KogitoApplication], contextInitializerClasses = [org.kie.kogito.index.spring.KogitoServiceRandomPortSpringTestResource, org.kie.kogito.index.spring.DataIndexPostgreSqlSpringTestResource], activeProfiles = [], propertySourceDescriptors = [], propertySourceProperties = ["org.springframework.boot.test.context.SpringBootTestContextBootstrapper=true", "server.port=0"], contextCustomizers = [org.springframework.boot.test.context.filter.ExcludeFilterContextCustomizer@6f1c29b7, org.springframework.boot.test.json.DuplicateJsonObjectContextCustomizerFactory$DuplicateJsonObjectContextCustomizer@2a7ed1f, org.springframework.boot.test.mock.mockito.MockitoContextCustomizer@0, org.springframework.boot.test.web.client.TestRestTemplateContextCustomizer@5456afaa, org.springframework.boot.test.autoconfigure.actuate.observability.ObservabilityContextCustomizerFactory$DisableObservabilityContextCustomizer@1f, org.springframework.boot.test.autoconfigure.properties.PropertyMappingContextCustomizer@0, org.springframework.boot.test.autoconfigure.web.servlet.WebDriverContextCustomizer@1787bc24, org.springframework.boot.test.context.SpringBootTestAnnotation@bf04646b], resourceBasePath = "src/main/webapp", contextLoader = org.springframework.boot.test.context.SpringBootContextLoader, parent = null]

PR check / Build projects / org.kie.kogito.it.jobs.ProcessTimerIT.testDeleteTimerCycle

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.test.resources.JobServiceCompositeQuarkusTestResource

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon

java.util.concurrent.CompletionException: java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource

PR check / Build projects / org.kie.kogito.addons.quarkus.data.index.it.PostgreSQLQuarkusAddonDataIndexPersistenceIT.testDataIndexAddon

java.lang.RuntimeException: Unable to start Quarkus test resource class org.kie.kogito.index.test.quarkus.http.DataIndexPostgreSqlHttpQuarkusTestResource

gitgabrio · 2024-10-24T08:28:04Z

jenkins failure unrelated

Caused by: com.google.api.client.http.HttpResponseException: 502 Bad Gateway

…he#6135) * kie-issues#1541: Add testing models into kie-dmn-test-resources This PR is related to: apache/incubator-kie-kogito-apps#2120 where we are adding new unit tests using DMN models from the drools/kie-dmn/kie-dmn-test-resources * Collections.dmn -> MultipleHitRules.dmn * Remove <output/> name attribute

… jitexecutor-dmn’s “/dmnresult” route (apache#2120) * exp_dmn_result_mapped_to_input * [exp_dmn_result_mapped_to_input] WIP * [incubator-kie-issues#1541] WIP * [incubator-kie-issues#1541] Implemented retrieval and population of "evaluationHitIds" field * [incubator-kie-issues#1541] Fixed tests. Minor refactoring * [incubator-kie-issues#1541] Fix formatting * [incubator-kie-issues#1541] Fix as per suggestion * [incubator-kie-issues#1541] Fix as per suggestion * kie-issues#1541: Extend test coverage - test DMN model where a decision table is nested under conditional expression - test DMN model where collection data type is used as input and output * Collections -> MultipleHitRules * [incubator-kie-issues#1541] Remove duplicated test * [incubator-kie-issues#1541] Fix imports --------- Co-authored-by: Gabriele-Cardosi <[email protected]> Co-authored-by: Jozef Marko <[email protected]>

Gabriele-Cardosi added 7 commits July 30, 2024 14:46

exp_dmn_result_mapped_to_input

19468f7

[exp_dmn_result_mapped_to_input] WIP

85b7f5b

Merge remote-tracking branch 'origin/main' into exp_dmn_result_mapped…

8712533

…_to_input

[incubator-kie-issues#1541] WIP

9d6bb05

[incubator-kie-issues#1541] Implemented retrieval and population of "…

411a8b4

…evaluationHitIds" field

[incubator-kie-issues#1541] Fixed tests. Minor refactoring

ffb4f32

Merge remote-tracking branch 'origin/main' into incubator-kie-issues#…

6703fd4

…1541

gitgabrio requested review from baldimir, jomarko and yesamer October 18, 2024 10:02

yesamer approved these changes Oct 21, 2024

View reviewed changes

Gabriele-Cardosi added 2 commits October 21, 2024 10:43

[incubator-kie-issues#1541] Fix formatting

81caaa3

[incubator-kie-issues#1541] Fix as per suggestion

d8c75c0

jomarko reviewed Oct 21, 2024

View reviewed changes

[incubator-kie-issues#1541] Fix as per suggestion

03e14bc

jomarko mentioned this pull request Oct 22, 2024

kie-issues#1541: Add testing models into kie-dmn-test-resources apache/incubator-kie-drools#6135

Merged

jomarko added 2 commits October 22, 2024 12:46

kie-issues#1541: Extend test coverage

f9a7501

- test DMN model where a decision table is nested under conditional expression - test DMN model where collection data type is used as input and output

Collections -> MultipleHitRules

a53d1f5

gitgabrio and others added 2 commits October 23, 2024 09:31

Merge pull request #1 from jomarko/evaluationhits

e6ad9b4

kie-issues#1541: Extend test coverage

Merge remote-tracking branch 'origin/main' into incubator-kie-issues#…

6246904

…1541

jomarko approved these changes Oct 23, 2024

View reviewed changes

[incubator-kie-issues#1541] Remove duplicated test

87f00d2

baldimir approved these changes Oct 23, 2024

View reviewed changes

Gabriele-Cardosi added 2 commits October 23, 2024 13:44

[incubator-kie-issues#1541] Fix imports

be0aa26

Merge remote-tracking branch 'origin/main' into incubator-kie-issues#…

cc544f7

…1541

gitgabrio merged commit 7b582c8 into apache:main Oct 24, 2024
4 of 5 checks passed

gitgabrio deleted the incubator-kie-issues#1541 branch October 24, 2024 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[incubator-kie-issues#1541] Add “evaluationHitIds” to the response of jitexecutor-dmn’s “/dmnresult” route #2120

[incubator-kie-issues#1541] Add “evaluationHitIds” to the response of jitexecutor-dmn’s “/dmnresult” route #2120

gitgabrio commented Oct 18, 2024

yesamer left a comment

yesamer Oct 21, 2024

yesamer Oct 21, 2024

yesamer Oct 21, 2024

jomarko left a comment

jomarko Oct 21, 2024

jomarko Oct 21, 2024

gitgabrio Oct 21, 2024

kie-ci3 commented Oct 21, 2024

jomarko left a comment

gitgabrio commented Oct 23, 2024

kie-ci3 commented Oct 23, 2024

kie-ci3 commented Oct 23, 2024

gitgabrio commented Oct 24, 2024

[incubator-kie-issues#1541] Add “evaluationHitIds” to the response of jitexecutor-dmn’s “/dmnresult” route #2120

[incubator-kie-issues#1541] Add “evaluationHitIds” to the response of jitexecutor-dmn’s “/dmnresult” route #2120

Conversation

gitgabrio commented Oct 18, 2024

yesamer left a comment

Choose a reason for hiding this comment

yesamer Oct 21, 2024

Choose a reason for hiding this comment

yesamer Oct 21, 2024

Choose a reason for hiding this comment

yesamer Oct 21, 2024

Choose a reason for hiding this comment

jomarko left a comment

Choose a reason for hiding this comment

jomarko Oct 21, 2024

Choose a reason for hiding this comment

jomarko Oct 21, 2024

Choose a reason for hiding this comment

gitgabrio Oct 21, 2024

Choose a reason for hiding this comment

kie-ci3 commented Oct 21, 2024

jomarko left a comment

Choose a reason for hiding this comment

gitgabrio commented Oct 23, 2024

kie-ci3 commented Oct 23, 2024

kie-ci3 commented Oct 23, 2024

gitgabrio commented Oct 24, 2024