-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-7840] - Add validation on Workflow Metadata with admission we… #361
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for tangerine-crostata-04a6bf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spolti, Your changes look good to me. Thank you!
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good once comment from Marian is addressed
Please, merge only after https://github.com/kiegroup/kogito-serverless-operator/pull/153 is merged. |
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
…bhooks Signed-off-by: Spolti <[email protected]>
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Spolti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mixed up with and without webhooks. Can you please review your last changes ? :)
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Spolti <[email protected]>
@kaldesai can you take a second look, please? There are a few changes since your last review. |
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini @spolti
I have added my suggestions. Otherwise, the content looks good to me. Thank you!
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/install-serverless-operator.adoc
Outdated
Show resolved
Hide resolved
…erverless-operator.adoc Co-authored-by: Kalyani Desai <[email protected]>
…erverless-operator.adoc Co-authored-by: Tristan Radisson <[email protected]>
@ricardozanini please is this ok to be merged? |
@domhanak I'd rather wait for apache/incubator-kie-kogito-serverless-operator#239 to be merged first. And we need two PRs that are opened (Jobs Service, Build Fix, Svc Discovery) to be merged first |
…bhooks
JIRA:
Description:
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.