Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-7840] - Add validation on Workflow Metadata with admission we… #361

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spolti
Copy link
Member

@spolti spolti commented Jun 6, 2023

…bhooks

JIRA:

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for tangerine-crostata-04a6bf ready!

Name Link
🔨 Latest commit 7e89ec5
🔍 Latest deploy log https://app.netlify.com/sites/tangerine-crostata-04a6bf/deploys/64f8842638ad6a0008982e71
😎 Deploy Preview https://deploy-preview-361--tangerine-crostata-04a6bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spolti, Your changes look good to me. Thank you!

@spolti spolti requested a review from radtriste June 9, 2023 12:13
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good once comment from Marian is addressed

@spolti
Copy link
Member Author

spolti commented Jun 9, 2023

Please, merge only after https://github.com/kiegroup/kogito-serverless-operator/pull/153 is merged.

@spolti spolti added the DO_NOT_MERGE 🙅 don't merge this PR label Jun 9, 2023
Copy link
Contributor

@radtriste radtriste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mixed up with and without webhooks. Can you please review your last changes ? :)

Signed-off-by: Spolti <[email protected]>
@ricardozanini
Copy link
Member

@kaldesai can you take a second look, please? There are a few changes since your last review.

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini @spolti
I have added my suggestions. Otherwise, the content looks good to me. Thank you!

spolti and others added 2 commits September 6, 2023 10:52
…erverless-operator.adoc

Co-authored-by: Tristan Radisson <[email protected]>
@domhanak
Copy link
Contributor

@ricardozanini please is this ok to be merged?

@ricardozanini
Copy link
Member

@domhanak I'd rather wait for apache/incubator-kie-kogito-serverless-operator#239 to be merged first. And we need two PRs that are opened (Jobs Service, Build Fix, Svc Discovery) to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_MERGE 🙅 don't merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants