Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-8410 Added documentation about GET requests to Knative Custom Functions #451

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

hbelmiro
Copy link
Contributor

JIRA: https://issues.redhat.com/browse/KOGITO-8410

This PR depends on:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for tangerine-crostata-04a6bf ready!

Name Link
🔨 Latest commit e679f93
🔍 Latest deploy log https://app.netlify.com/sites/tangerine-crostata-04a6bf/deploys/64da3d5dcc31f900084dec25
😎 Deploy Preview https://deploy-preview-451--tangerine-crostata-04a6bf.netlify.app/serverlessworkflow/latest/core/custom-functions-support
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ricardozanini
Copy link
Member

Maybe adding a note saying that the arguments are sent over query string? I know that's obvious, but....

@hbelmiro
Copy link
Contributor Author

Maybe adding a note saying that the arguments are sent over query string? I know that's obvious, but....

Done.

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbelmiro Your changes look good to me. Thank you.

@radtriste radtriste merged commit aa227b2 into apache:main Aug 16, 2023
5 checks passed
@ricardozanini
Copy link
Member

@radtriste we should've waited for https://github.com/kiegroup/kogito-runtimes/pull/3172

But I guess we haven't branched? If so, that PR must be cherry-picked.

@radtriste
Copy link
Contributor

sorry I saw it after ...
branch was done 2 days ago already ... so there is no cherry-pick needed. it will end up in 1.44

@hbelmiro hbelmiro deleted the KOGITO-8410 branch August 16, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants