Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-9145 Added information about kogito-addons-quarkus-microprofile-config-service-catalog #462

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

hbelmiro
Copy link
Contributor

JIRA: https://issues.redhat.com/browse/KOGITO-9145

This PR depends on:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…e-config-service-catalog

Signed-off-by: Helber Belmiro <[email protected]>
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for tangerine-crostata-04a6bf ready!

Name Link
🔨 Latest commit ab2e7ad
🔍 Latest deploy log https://app.netlify.com/sites/tangerine-crostata-04a6bf/deploys/64e5fb718e0e1c000811b572
😎 Deploy Preview https://deploy-preview-462--tangerine-crostata-04a6bf.netlify.app/serverlessworkflow/latest/cloud/quarkus/kubernetes-service-discovery
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

You can enable the Kubernetes service discovery by adding a service discovery implementation to the application's dependencies as shown in the following Maven dependencies:

==== Fabric8 Kubernetes Service Catalog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Fabric8 Kubernetes Service Catalog
==== Fabric8 Kubernetes service catalog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the name of the module. So, I think uppercase is fine.

<groupId>org.kie.kogito</groupId>
<artifactId>kogito-addons-quarkus-fabric8-kubernetes-service-catalog</artifactId>
</dependency>
----

=== Available service discovery implementations
==== MicroProfile Config Kubernetes Service Catalog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== MicroProfile Config Kubernetes Service Catalog
==== MicroProfile Config Kubernetes service catalog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbelmiro Very minor suggestions. Otherwise, your content looks good to me. Thank you!

@ricardozanini ricardozanini merged commit 37596df into apache:main Aug 28, 2023
5 checks passed
@hbelmiro hbelmiro deleted the KOGITO-9145 branch August 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants