-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incubator-kie-issues#471: Add apache headers license into files #512
Conversation
744e7dc
to
e98d7a4
Compare
Can you please rebase? 🙏 |
e98d7a4
to
713c456
Compare
@ricardozanini rebased |
<<<<<<< HEAD | ||
curl -S https://raw.githubusercontent.com/apache/incubator-kie-kogito-serverless-operator/{operator_version}/test/testdata/sonataflow.org_v1alpha08_sonataflow_devmode.yaml > workflow_devmode.yaml | ||
======= | ||
curl -S https://raw.githubusercontent.com/apache/incubator-kie-kogito-serverless-operator/{operator_version}/config/samples/sw.kogito_v1alpha08_sonataflow_devmode.yaml > workflow_devmode.yaml | ||
>>>>>>> 744e7dc (kiegroup -> apache) | ||
code workflow_devmode.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this conflict hasn't been solved and has been left behind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for spotting @porcelli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
JIRA:
Closes: apache/incubator-kie-issues#471
Please notice I am not adding headers to all
.adoc
files, because on apache pages is written it is not needed for code snippet that is included into some parent, that has header https://www.apache.org/legal/src-headers.html#faq-exceptionsThis PR also replaces github kiegroup references to github apache references
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.