Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding managed properties #527

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

dmartinol
Copy link
Contributor

Closes/Fixes/Resolves SRVLOGIC-195

Description:
Added specification of the managed properties concept and of the associated ConfigMap

@dmartinol
Copy link
Contributor Author

@ricardozanini please TAL
Note: I probably need more details about the other managed properties from those who developed the discovery and data-index/Job-service features.

@ricardozanini ricardozanini requested review from ricardozanini, wmedvede and nmirasch and removed request for MarianMacik January 31, 2024 15:00
@ricardozanini
Copy link
Member

@nmirasch @wmedvede can you please validate the JS/DI sections?

@ricardozanini
Copy link
Member

@nmirasch @wmedvede it's been a month, can you guys please take a look?

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments if you don't mind. I'm sorry about the late review.

@ricardozanini
Copy link
Member

@kaldesai can you take a quick look? Thanks!

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

@ricardozanini
Copy link
Member

@dmartinol can you please rebase so we can check for errors? We've updated our CI to reflect that.

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the comments and it is good to go.

@dmartinol
Copy link
Contributor Author

Hi Team, it took a very long time to receive your comments: I will try to apply the required changes but please try to avoid such delays.
In case my updates will not satisfy your comments, please consider pulling my branch and create a new PR.
FYI, @pkliczewski

@ricardozanini
Copy link
Member

@dmartinol I'm sorry again for the late review. There's no excuse, that slipped my review list. We will improve our review process.

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing CI errors.

@ricardozanini ricardozanini merged commit 396880b into apache:main Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants