-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding managed properties #527
Conversation
@ricardozanini please TAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments if you don't mind. I'm sorry about the late review.
serverlessworkflow/modules/ROOT/pages/cloud/operator/configuring-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/cloud/operator/configuring-workflows.adoc
Outdated
Show resolved
Hide resolved
@kaldesai can you take a quick look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
@dmartinol can you please rebase so we can check for errors? We've updated our CI to reflect that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's resolve the comments and it is good to go.
…ng-workflows.adoc Co-authored-by: Ricardo Zanini <[email protected]>
Hi Team, it took a very long time to receive your comments: I will try to apply the required changes but please try to avoid such delays. |
@dmartinol I'm sorry again for the late review. There's no excuse, that slipped my review list. We will improve our review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing CI errors.
Closes/Fixes/Resolves SRVLOGIC-195
Description:
Added specification of the
managed properties
concept and of the associatedConfigMap