Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-kogito-docs-574 - Add prepare environment guide for sonataflow #575

Merged
merged 14 commits into from
Mar 14, 2024
Merged

kie-kogito-docs-574 - Add prepare environment guide for sonataflow #575

merged 14 commits into from
Mar 14, 2024

Conversation

domhanak
Copy link
Contributor

Resolves #574

Description:
Adds new chapters that should allow us to unify all environment configurations needed for users to work with our guides

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024 •
edited
Loading

🎊 PR Preview d52ae5c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-575.surge.sh

@domhanak
Copy link
Contributor Author

domhanak commented Mar 11, 2024 •
edited
Loading

@ricardozanini @wmedvede @nmirasch @fjtirado drafting this idea for unification of the env setup. Please suggest what you think is good and what is not.

@domhanak domhanak changed the title 574 kie-kogito-docs-574 - Add prepare environment guide for sonataflow Mar 11, 2024
@domhanak domhanak added the serverless-workflow All issue targetting serverless workflow domain label Mar 11, 2024
@domhanak domhanak self-assigned this Mar 11, 2024
@fjtirado
Copy link
Contributor

fjtirado commented Mar 11, 2024 •
edited
Loading

I do not know if we should include java embedded environment as starting up.
See for example https://github.com/fjtirado/java-flow/blob/main/java-flow-example/src/main/java/org/kie/kogito/serverless/workflow/examples/HelloWorld.java
You just need Java and one dependency in your pom

@ricardozanini
Copy link
Member

@domhanak pretty neat!
@fjtirado we will, but once we restructure to target personas: the cloud dev and the java dev use cases.

@domhanak domhanak marked this pull request as ready for review March 12, 2024 08:26
@domhanak domhanak requested a review from krisv as a code owner March 12, 2024 08:26
ricardozanini
ricardozanini approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty nice addition!

@domhanak domhanak merged commit 49a9bc4 into apache:main Mar 14, 2024
2 checks passed
@domhanak domhanak mentioned this pull request Mar 14, 2024
Closed
@domhanak
Copy link
Contributor Author

Resolves #550

@domhanak domhanak mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmedvede wmedvede wmedvede approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

@krisv krisv krisv approved these changes

Assignees

@domhanak domhanak

Labels
serverless-workflow All issue targetting serverless workflow domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prepare environment guide for sonataflow
5 participants
@domhanak @fjtirado @ricardozanini @krisv @wmedvede