Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #526] Document and give example of JSON in data #582

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 12, 2024

Fixes #526

Description:
As per subject. Also adds function of type expression and more info on $SECRET data type.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

🎊 PR Preview d52ae5c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-582.surge.sh

@fjtirado fjtirado requested a review from gmunozfe March 12, 2024 16:04
Also adding function of type expression and more info on $SECRET data
type
@fjtirado fjtirado changed the title [Fix #3436] Document and give example of JSON in data [Fix #526] Document and give example of JSON in data Mar 12, 2024
@ricardozanini
Copy link
Member

@kaldesai can you please take a look?

Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, perfectly done @fjtirado !

@fjtirado fjtirado merged commit cfa237a into apache:main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document and give example of JSON in data
5 participants