-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KOGITO-9458: Create the detailed guide about running a quarkus workfl… #604
Conversation
🎊 PR Preview 22b022b has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-604.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you. I will definitely try to add something similar for non quarkus side.
I started with review and added some suggestions and comments, will look at rest tomorrow. No need to accept them all.
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
@domhanak suggestions applied. Could you take a look when you have a chance? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished the review, tried to suggest way to remove the we
and use you
as suggested in the contribution guide. Let me know,
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
@kaldesai ptal |
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…lain the need of eventing
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc Co-authored-by: Dominik Hanák <[email protected]>
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
...e-cases/advanced-developer-use-cases/getting-started/create-your-first-workflow-project.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmirasch Some basic suggestions. Otherwise, your content looks good to me. Thank you!
@kaldesai suggestions applied, thank you very much for the review!! |
…ow project
https://issues.redhat.com/browse/KOGITO-9458
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.