Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-9458: Create the detailed guide about running a quarkus workfl… #604

Merged
merged 20 commits into from
Mar 28, 2024

Conversation

nmirasch
Copy link
Contributor

…ow project

https://issues.redhat.com/browse/KOGITO-9458

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Contributor

github-actions bot commented Mar 25, 2024

🎊 PR Preview 22b022b has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-604.surge.sh

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you. I will definitely try to add something similar for non quarkus side.

I started with review and added some suggestions and comments, will look at rest tomorrow. No need to accept them all.

@nmirasch
Copy link
Contributor Author

@domhanak suggestions applied. Could you take a look when you have a chance? thanks!

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm flabbergasted. This guide is great and gives a great introduction to SonataFlow Java project. Great work, @nmirasch!

@kaldesai can you please take a look?

Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the review, tried to suggest way to remove the we and use you as suggested in the contribution guide. Let me know,

@domhanak
Copy link
Contributor

@kaldesai ptal

nmirasch and others added 18 commits March 26, 2024 16:39
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
…oper-use-cases/getting-started/create-your-first-workflow-project.adoc

Co-authored-by: Dominik Hanák <[email protected]>
Copy link
Contributor

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmirasch Some basic suggestions. Otherwise, your content looks good to me. Thank you!

@nmirasch
Copy link
Contributor Author

@kaldesai suggestions applied, thank you very much for the review!!

@ricardozanini ricardozanini merged commit 1125bde into apache:main Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants