Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-598 Holistic review of non-quarkus data index chapter #613

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Issue-598 Holistic review of non-quarkus data index chapter #613

merged 1 commit into from
Apr 3, 2024

Conversation

gmunozfe
Copy link
Contributor

@gmunozfe gmunozfe commented Apr 2, 2024 •
edited
Loading

Closes/Fixes/Resolves #598

Description: Holistic review of non-quarkus data-index chapter.
Also fixed references to kogito-addons which have changed to kie-addons.

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description

@gmunozfe gmunozfe requested a review from nmirasch April 2, 2024 21:29
@gmunozfe gmunozfe requested a review from domhanak as a code owner April 2, 2024 21:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

🎊 PR Preview cae59fa has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-613.surge.sh

domhanak
domhanak approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🔥

nmirasch
nmirasch approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@nmirasch nmirasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@domhanak domhanak merged commit f55a384 into apache:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domhanak domhanak domhanak approved these changes

@nmirasch nmirasch nmirasch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Holistic review of non-quarkus data index chapter
3 participants
@gmunozfe @nmirasch @domhanak