Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-629 - Remove infinispan and mongodb refs from Data Index guides #636

Merged
merged 1 commit into from
May 23, 2024

Conversation

domhanak
Copy link
Contributor

Closes #629

Removed the references

CC @nmirasch I touched on couple of paragraphs at the start of the guide. Let me know if you think it is ok please.

Copy link
Contributor

github-actions bot commented May 22, 2024

🎊 PR Preview a412e50 has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-636.surge.sh

Copy link
Contributor

@nmirasch nmirasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Then only thing is the commit message that is using inifnispan ;-)

@domhanak
Copy link
Contributor Author

@nmirasch oh ty, fixed

@domhanak domhanak changed the title Issue-629 - Remove inifnispan and mongodb refs from Data Index guides Issue-629 - Remove infinispan and mongodb refs from Data Index guides May 22, 2024
@domhanak domhanak removed the request for review from gmunozfe May 23, 2024 06:04
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good work @domhanak !

@ricardozanini ricardozanini merged commit 692ab3e into apache:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Index documentation still refers to mongodb, oreacle and infinispan
5 participants