-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-kogito-docs-672: Create a new SonataFlow guide for Knative Eventing Integration with Jobs Service and Data Index #639
Conversation
…ng Integration with Jobs Service and Data Index
🎊 PR Preview ce2e35c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-639.surge.sh |
Hi @kaldesai , would you mind review this PR? |
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng-knative-eventing-resources.adoc Co-authored-by: Kalyani Desai <[email protected]>
…ng-knative-eventing-resources.adoc Co-authored-by: Kalyani Desai <[email protected]>
…ng-knative-eventing-resources.adoc Co-authored-by: Kalyani Desai <[email protected]>
…ng-knative-eventing-resources.adoc Co-authored-by: Kalyani Desai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat! Just non-blocker comments.
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Outdated
Show resolved
Hide resolved
...erlessworkflow/modules/ROOT/pages/cloud/operator/configuring-knative-eventing-resources.adoc
Show resolved
Hide resolved
namespace: example-namespace | ||
---- | ||
|
||
:sectnums!: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a brief section explaining how to verify that the setup is working? Maybe pointing to another doc that shows that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can try to add something, but we are running out-of-time at the same time. I think, we should merge this, try to finish the revisting of the supporting services guide, and hopefully, add more stuff on this.
…ng-knative-eventing-resources.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…ng-knative-eventing-resources.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…ng-knative-eventing-resources.adoc Co-authored-by: Ricardo Zanini <[email protected]>
…ng-knative-eventing-resources.adoc Co-authored-by: Ricardo Zanini <[email protected]>
Closes #627
Description:
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject
[0.9.x] Issue-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.