Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] KN workflow plugin installation #665

Closed
wants to merge 2 commits into from

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented Jul 8, 2024

Closes/Fixes/Resolves #ISSUE-NUMBER

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@wmedvede wmedvede requested a review from domhanak as a code owner July 8, 2024 07:08
@wmedvede wmedvede requested review from ricardozanini and domhanak and removed request for domhanak and ricardozanini July 8, 2024 07:08
@wmedvede wmedvede closed this Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

🎊 PR Preview 618455c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-665.surge.sh

@wmedvede wmedvede reopened this Jul 8, 2024

https://75129--ocpdocs-pr.netlify.app/openshift-serverless/latest/install/installing-kn

* You have first installed the link:https://76490--ocpdocs-pr.netlify.app/openshift-serverless/latest/install/installing-kn[Knative CLI].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a link to official community documentation of knative

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we can change that link.
But please note that this PR is just a draft to share what the proposal of installing the kn workflow plugin was. IDK if we are publishing that image in community·

@domhanak
Copy link
Contributor

Closing now, thanks @wmedvede for the effort.

@domhanak domhanak closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants