-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-1477] bump maven version to 3.8.6 #1666
Conversation
@radtriste @cristianonicolai |
Personally, I don't use it, but not sure if others find it useful. |
@fjtirado wrapper are not used by the CI. Not sure if we want to follow that direction. Could be useful... With the possible move to Apache, we will need to remove any binaries anyway so the jar cannot be there but the rest can (properties + java to download) |
I realize I'm using fedora 36 and that comes with maven 3.8.4. Fedora 38 (official release) has 3.8.6 so after upgrade It will be fine to use mvn directly. I'm ok with removing this wrapper. In any case, if it is available, match minimum maven version required should be just fine, no? |
I vote for removing this directory so one thing less to do (remember to upgrade it to the minimum required version) |
I also vote for removing the wrapper. If we decide to remove it, we need to make sure it is replaced also in the documentation and in READMEs if it is mentioned somewhere. |
wrapper is easily forgotten to be updated as this PR shows |
Closing as stale, current maven we use is |
match maven minimum version
required at least on https://github.com/kiegroup/kogito-examples/tree/main/kogito-quarkus-examples/process-scripts-quarkus