Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KOGITO-1477] bump maven version to 3.8.6 #1666

Closed
wants to merge 1 commit into from
Closed

Conversation

albfan
Copy link

@albfan albfan commented May 15, 2023

@fjtirado
Copy link
Contributor

@radtriste @cristianonicolai
Should we still use maven wrapper or is it better to remove it?

@cristianonicolai
Copy link
Contributor

Personally, I don't use it, but not sure if others find it useful.

@radtriste
Copy link
Contributor

@fjtirado wrapper are not used by the CI. Not sure if we want to follow that direction. Could be useful...
I have a long running issue to add wrapper a bit everywhere to follow the Maven version but never had time to complete it
I guess it does not hurt yet to keep it.

With the possible move to Apache, we will need to remove any binaries anyway so the jar cannot be there but the rest can (properties + java to download)

@albfan
Copy link
Author

albfan commented May 16, 2023

I realize I'm using fedora 36 and that comes with maven 3.8.4. Fedora 38 (official release) has 3.8.6 so after upgrade It will be fine to use mvn directly.

I'm ok with removing this wrapper. In any case, if it is available, match minimum maven version required should be just fine, no?

@fjtirado
Copy link
Contributor

fjtirado commented May 16, 2023

I vote for removing this directory so one thing less to do (remember to upgrade it to the minimum required version)
If users want to sue mvn wrapper for some reason, they can run it manually.

@baldimir
Copy link
Contributor

I also vote for removing the wrapper. If we decide to remove it, we need to make sure it is replaced also in the documentation and in READMEs if it is mentioned somewhere.

@porcelli
Copy link

wrapper is easily forgotten to be updated as this PR shows

@domhanak domhanak added the stale This label is for items that are stale with no activity for more than a month label Mar 1, 2024
@domhanak
Copy link

domhanak commented Mar 7, 2024

Closing as stale, current maven we use is 3.9.6 so this is not relevant.
Please follow up here - #1890

@domhanak domhanak closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This label is for items that are stale with no activity for more than a month
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants