[KOGITO-9483] - fix wflow and few formating fixes #1717
Conversation
spolti
requested review from
cristianonicolai,
ricardozanini,
MarianMacik,
fjtirado and
VaniHaripriya
Signed-off-by: Your Name <[email protected]>
| "functionRef": { | ||
| "refName": "PrintOutput", | ||
| "arguments": { | ||
| "message": "completed" |
There was a problem hiding this comment.
| "message": "completed" | |
| "message": "Compensate completed" |
to distinguish finish_compensate and finish_not_compensate?
There was a problem hiding this comment.
I think we should not add the print action at all and leave the flow as it was (fixing the fomatting if we want but thats it)
There was a problem hiding this comment.
In fact, besides the readme change (removing the quotes for the boolean, which was a typo), I do not think this PR should have been opened
There was a problem hiding this comment.
if you think that the action should not do nothing, it is even better to remove that, at least for me, have empty action list does not make sense.
imho what we can do is, remove the action, change to something else or keep the action with sysout.
What we can't have is one sdk accepting empty array list while the spec mentions that action can't be null, while the other sdk, requires at least one action.
There was a problem hiding this comment.
To satisfy the spec and to showcase the compensation, I think this is OK.
|
Sorry to play the bad guy, but whats the point of adding a sysout at the end when the discrminator is the returned model? |
|
Will we merge this? |
|
We won't do anything on the spec side. |
ok, how will we proceed to align the java and go-sdk? |
We can relax the validation in the go-sdk |
|
sounds good, will close this and create the jira to address it on the go-sdk. |
Many thanks for submitting your Pull Request ❤️!
See: https://issues.redhat.com/browse/KOGITO-9483
Please make sure that your PR meets the following requirements:
WARNING! Please make sure you are opening your PR against
mainbranch!KOGITO-XYZ Subject[0.9.x] KOGITO-XYZ SubjectHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.