Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quarkus-lts patch to align protobuf and grpc versions #1751

Merged
merged 3 commits into from
Aug 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
diff --git a/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml b/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml
index c2ca6f930..a50429305 100644
--- a/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml
+++ b/serverless-workflow-examples/serverless-workflow-greeting-rpc-quarkus/serverless-workflow-greeting-server-rpc-quarkus/pom.xml
@@ -15,8 +15,9 @@
<version.compiler.plugin>3.8.1</version.compiler.plugin>
<maven.compiler.release>11</maven.compiler.release>
<version.surefire.plugin>3.0.0-M7</version.surefire.plugin>
- <version.com.google.protobuf>3.22.0</version.com.google.protobuf>
- <version.io.grpc>1.51.1</version.io.grpc>
+ <!-- Quarkus 2.13.x is using protobuf 3.19.6, but the correct version should be 3.21.1 to work properly with current io.grpc version -->
+ <version.com.google.protobuf>3.21.1</version.com.google.protobuf>
+ <version.io.grpc>1.49.0</version.io.grpc>
<version.kr.motd.maven.os>1.6.0</version.kr.motd.maven.os>
<version.org.xolstice.maven.protobuf>0.6.1</version.org.xolstice.maven.protobuf>
<version.jib-maven-plugin>3.3.0</version.jib-maven-plugin>
Loading