Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating new profile from openvino example #1825

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Nov 13, 2023

This will prevent huge image (this example requires a lot of python libraries)

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we have to run a separate pipeline to validate the Python use case?

@kie-ci3
Copy link
Contributor

kie-ci3 commented Nov 13, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #1825 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-1825/1/display/redirect

Test results:

  • PASSED: 376
  • FAILED: 2

Those are the test failures:

org.kie.kogito.quarkus.outbox.OutboxIT.(?) org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8083, 57631] should be listening)
org.kie.kogito.springboot.outbox.OutboxIT.(?) org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8083, 57679] should be listening)

@ricardozanini
Copy link
Member

@wmedvede @fjtirado This OutboxIT test serves for what purpose? This test has been failing from the beginning of time. I think we should either remove it or solve this flaky test for once.

@jstastny-cz
Copy link

@wmedvede @fjtirado This OutboxIT test serves for what purpose? This test has been failing from the beginning of time. I think we should either remove it or solve this flaky test for once.

+1 , that one is unstable even in my dind image attempts, so does not seem to be env port conflict or sth.

@wmedvede
Copy link
Contributor

@wmedvede @fjtirado This OutboxIT test serves for what purpose? This test has been failing from the beginning of time. I think we should either remove it or solve this flaky test for once.

IDK, as you said, it looks like this test has been failing from the beginning of time, and nobody has ever used it. I'll take a look, maybe it's time to remove it.

@ricardozanini
Copy link
Member

Thanks @wmedvede. Let's remove/disable it and open a kie-issue to track it down. If someone asks, we can point to the issue and the person can fix the test.

Copy link

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fjtirado fjtirado merged commit 326b316 into apache:main Nov 16, 2023
3 of 4 checks passed
rgdoliveira pushed a commit to kiegroup/kogito-examples that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants