Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-kogito-runtimes#2608] Testing multiple DMNs, importing dmn #1888

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

gitgabrio
Copy link
Contributor

Fixes apache/incubator-kie-kogito-runtimes#2608
Depends on apache/incubator-kie-kogito-runtimes#3424

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [kogito-examples] tests

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit doubtful about the management of this case.
Not sure if modifying the original example is the best choice, I guess this example could be referenced in other places (blog post, documentation) so I would consider keeping it and managing the Imported model case in a new example, WDYT?

However, if we decide to merge this PR as it is, please update the Readme file of the module accordingly to the changes.

<dmn:typeRef>number</dmn:typeRef>
</dmn:itemComponent>
</dmn:itemDefinition>
<!-- <dmn:itemDefinition id="_63824D3F-9173-446D-A940-6A7F0FA056BB" name="tDriver" isCollection="false">-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitgabrio is it possible to remove this block of commented code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gitgabrio
Copy link
Contributor Author

I'm a bit doubtful about the management of this case. Not sure if modifying the original example is the best choice, I guess this example could be referenced in other places (blog post, documentation) so I would consider keeping it and managing the Imported model case in a new example, WDYT?

However, if we decide to merge this PR as it is, please update the Readme file of the module accordingly to the changes.

Created new kogito-example

### Prerequisites

You will need:
- Java 11+ installed
Copy link
Contributor

@yesamer yesamer Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitgabrio not an issue with your PR, I guess we need to update the JDK and maven versions in all examples considering that now the engines require jdk 17 and maven 3.9.5, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔
Yes, I think we should update all the readme... maybe another ticket, anyway, to do an atomic change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, it can be done in this PR #1885, I already asked if is possible. If not, we can create a new PR

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gitgabrio LGTM

@gitgabrio gitgabrio merged commit fe24887 into apache:main Mar 8, 2024
4 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-kogito-runtimes#2608 branch March 8, 2024 07:59
rgdoliveira pushed a commit to rgdoliveira/kogito-examples that referenced this pull request Mar 11, 2024
… dmn (apache#1888)

* [incubator-kie-kogito-runtimes#2608] Testing multiple DMNs, importing dmn

* [incubator-kie-kogito-runtimes#2608] Restored dmn-quarkus-example. Created dmn-multiple-models-quarkus-example

* [incubator-kie-kogito-runtimes#2608] Restored dmn-quarkus-example. Created dmn-multiple-models-quarkus-example

* [incubator-kie-kogito-runtimes#2608] Removed commented block

* [incubator-kie-kogito-runtimes#2608] Fixed as per PR suggestion

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants