Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1123:unify maven projects configuration #1911

Merged
merged 4 commits into from
May 14, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 43 additions & 83 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@
<url>http://kogito.kie.org</url>
<inceptionYear>2019</inceptionYear>
<organization>
<name>JBoss by Red Hat</name>
<url>http://www.jboss.org/</url>
<name>The Apache Software Foundation</name>
<url>https://apache.org/</url>
</organization>

<licenses>
<license>
<name>Apache Software License, Version 2.0</name>
Expand All @@ -52,6 +53,46 @@
</license>
</licenses>

<scm>
<connection>scm:git:https://github.com/apache/incubator-kie-kogito-examples.git</connection>
<developerConnection>scm:git:https://github.com/apache/incubator-kie-kogito-examples.git</developerConnection>
<url>https://github.com/apache/incubator-kie-kogito-examples</url>
</scm>

<developers>
<developer>
<name>The Apache KIE Team</name>
<email>[email protected]</email>
<url>https://kie.apache.org</url>
<organization>Apache Software Foundation</organization>
<organizationUrl>http://apache.org/</organizationUrl>
</developer>
</developers>

<mailingLists>
<mailingList>
<name>Development List</name>
<subscribe>[email protected]</subscribe>
<unsubscribe>[email protected]</unsubscribe>
<post>[email protected]</post>
<archive>https://lists.apache.org/[email protected]</archive>
</mailingList>
<mailingList>
<name>User List</name>
<subscribe>[email protected]</subscribe>
<unsubscribe>[email protected]</unsubscribe>
<post>[email protected]</post>
<archive>https://lists.apache.org/[email protected]</archive>
</mailingList>
<mailingList>
<name>Commits List</name>
<subscribe>[email protected]</subscribe>
<unsubscribe>[email protected]</unsubscribe>
<post>[email protected]</post>
<archive>https://lists.apache.org/[email protected]</archive>
</mailingList>
</mailingLists>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Expand All @@ -77,80 +118,6 @@
<version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
</properties>

<!-- distributionManagement section -->
<distributionManagement>
<repository>
<id>apache-release-staging-repository</id>
<name>Apache Release Staging Repository</name>
<url>https://repository.apache.org/service/local/staging/deploy/maven2</url>
</repository>
<snapshotRepository>
<id>apache-snapshots-repository</id>
<name>Apache Snapshot Repository</name>
<url>https://repository.apache.org/content/repositories/snapshots/</url>
</snapshotRepository>
</distributionManagement>

<repositories>
<!-- Bootstrap repository to locate the parent pom when the parent pom
has not been build locally. -->
<repository>
<id>apache-public-repository-group</id>
<name>Apache Public Repository Group</name>
<url>https://repository.apache.org/content/groups/public/</url>
<layout>default</layout>
<releases>
<enabled>true</enabled>
<updatePolicy>never</updatePolicy>
</releases>
<snapshots>
<enabled>true</enabled>
<updatePolicy>daily</updatePolicy>
</snapshots>
</repository>
</repositories>

<pluginRepositories>
<pluginRepository>
<!-- Duplicating the Maven Central repository here (as it is already coming from Super POM) makes the build much faster,
as the Maven Central is now treated as the first (default) repository (because it is before the Apache Nexus one).
Artifacts with release (fixed) versions are being downloaded primarily from there. Without the central being the
first repository the Apache Nexus would be contacted first and since it is quite slow it slows down the build.
We use Apache Nexus repo only to download our SNAPSHOTs. -->
<id>central</id>
<name>Central Repository</name>
<url>https://repo.maven.apache.org/maven2</url>
<layout>default</layout>
<snapshots>
<enabled>false</enabled>
</snapshots>
</pluginRepository>
<pluginRepository>
<id>apache-public-repository-group</id>
<name>Apache Public Repository Group</name>
<url>https://repository.apache.org/content/groups/public/</url>
<releases>
<enabled>true</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>

<scm>
<connection>scm:git:https://github.com/apache/incubator-kie-kogito-examples.git</connection>
<developerConnection>scm:git:[email protected]:apache/incubator-kie-kogito-examples.git</developerConnection>
<url>https://github.com/apache/incubator-kie-kogito-examples</url>
</scm>

<developers>
<developer>
<name>All developers are listed in the KIE GitHub organization</name>
<url>https://github.com/orgs/kiegroup/people</url>
</developer>
</developers>

<profiles>
<profile>
<id>default</id>
Expand Down Expand Up @@ -271,13 +238,6 @@
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-deploy-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstastny-cz I guess you're removing it at all (and not just removing the overridden config like in the other PRs) because this repo's artifacts are not deployed, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pluginManagement section, so inherited from parent. Unless I misread the pom

<version>${version.deploy.plugin}</version>
<configuration>
<retryFailedDeploymentCount>10</retryFailedDeploymentCount>
</configuration>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>${version.compiler.plugin}</version>
Expand Down
Loading