Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1249] Fix REST call in process-rest-workitem-quarkus example #1926

Merged
merged 1 commit into from
May 23, 2024

Conversation

martinweiler
Copy link

Fixes apache/incubator-kie-issues#1249

Some points regarding the changes to fix this example:

  • Port needed to change from 80 to 8080 (added parameter in the WIH of the process)
  • The previous version of the example used Quarkus REST Client, this would have required a config change
  • With the REST client approach, the REST call was targeting https://petstore.swagger.io/v2/user/{user}. This call might have returned 200 for a demo user in the past, but now always returns 404. This makes it unusable for the example.
  • To simplify the example, I replaced the usage of the REST Client using petstore with a simple REST service within the application.

@martinweiler martinweiler added the bug Something isn't working label May 22, 2024
@martinweiler martinweiler self-assigned this May 22, 2024
@elguardian elguardian self-requested a review May 23, 2024 06:54
Copy link

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinweiler martinweiler merged commit 2f8e10e into apache:main May 23, 2024
6 checks passed
@LightGuard
Copy link

Thanks for the fix, @martinweiler!

rgdoliveira pushed a commit to rgdoliveira/kogito-examples that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🎯 Done
Development

Successfully merging this pull request may close these issues.

4 participants