Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.x] [incubator-kie-issues-1401] Fix build kogito-examples.build-and-test in kogito nightly.native folder #1986

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Jul 25, 2024

Issue:

Replaced remaining 999-SNAPSHOT with 10.0.999-SNAPSHOT

Why they were not updated by mvnVersionsUpdateParentAndChildModules / mvnSetVersionProperty in Jenkinsfile.setup-branch?
-> for serverless-workflow examples, the serverless-workflow-examples-parent itself was not updated.
-> for dmn-tracing-quarkus and trusty-tracing-quarkus-devservices, these examples are not in a valid state, so disabled in the parent pom (https://github.com/apache/incubator-kie-kogito-examples/pull/1930/files). Hence, they were not affected by mvn command. In other words, we can ignore the projects.

Completely disabled dmn-tracing-quarkus and trusty-tracing-quarkus-devservices

In https://github.com/apache/incubator-kie-kogito-examples/pull/1930/files , dmn-tracing-quarkus and trusty-tracing-quarkus-devservices were disabled, but still existed in native profile and kogito-apps-downstream profile. This PR removes them.

@tkobayas
Copy link
Contributor Author

tkobayas commented Jul 25, 2024

Note: This PR is fixing 10.0.x. If we recreate the 10.0.x branch with a job re-trigger, this PR is useless. A fundamental fix should be done in the main branch,

A. kogito-examples/.ci/jenkins/Jenkinsfile.setup-branch to completely update the versions in pom.xml from 999-SNAPSHOT to 10.0.999-SNAPSHOT

B. Completely disable dmn-tracing-quarkus and trusty-tracing-quarkus-devservices in the main branch as same as this PR

-> a PR for main : #1987

Copy link

@rodrigonull rodrigonull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @tkobayas

@tkobayas tkobayas merged commit fded63f into apache:10.0.x Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants