-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1599: Remove Task Console usage from kogito-examples #2033
base: main
Are you sure you want to change the base?
Conversation
3531484
to
13fec13
Compare
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2033 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2033/2/display/redirect Test results:
Those are the test failures: org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.testGrafanaDashboards1 expectation failed.JSON path title doesn't match. Expected: a collection containing "dmn-drools-quarkus-metrics_999-SNAPSHOT - Hello - Domain Dashboard" Actual: <[dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Operational Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - hello - Operational Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Domain Dashboard, dmn-drools-quarkus-metrics_999-SNAPSHOT - LoanEligibility - Operational Dashboard]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Nice cleanup. The feedback I share is based on executing scripts on Ubuntu 24.04.
kogito-quarkus-examples/process-usertasks-timer-quarkus-with-console/docker-compose/README.md
Show resolved
Hide resolved
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-examples -u #2033 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-examples-pr/job/PR-2033/4/display/redirect Test results:
Those are the test failures: org.kie.kogito.examples.quarkus.GrafanaDockerComposeIT.testGrafanaDashboards1 expectation failed.JSON path title doesn't match. Expected: a collection containing "dmn-drools-quarkus-metrics_999-SNAPSHOT - hello - Operational Dashboard" Actual: <[dmn-drools-quarkus-metrics_999-SNAPSHOT - Custom - Operational Dashboard]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updates @ljmotta . I was able to move forward with executing commands from README files, however spotted some errors good to mention before merge. Maybe they are expected?
|
||
``` | ||
mvn clean package | ||
java -jar target/quarkus-app/quarkus-run.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``` | ||
|
||
or | ||
|
||
```bash | ||
sh ./startServices.sh postgresql | ||
./startServices.sh postgresql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for updates in the README of this project, I was not able to finish the steps:
mvn clean install -DskipTests -Ppostgresql
🆗cd docker-compose
🆗./startServices.sh postgresql
🔴
getting this error:
Script requires your Kogito Quickstart to be compiled
Project version: 999-SNAPSHOT
Kogito Image version: main
Have you compiled the project before with the right profile: ../mvn clean install -DskipTests -Ppostgresql
WARNING: Found orphan containers (grafana, infinispan, prometheus) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
Creating docker-compose_postgres_1 ... done
Creating zookeeper ... done
Creating keycloak ... done
Creating docker-compose_pgadmin_1 ... done
Creating kafka ... done
Creating data-index ... done
Creating jobs-service ... done
ERROR: for management-console Container "3d084b0c7de2" is unhealthy.
ERROR: Encountered errors while bringing up the project.
Closes: apache/incubator-kie-issues#1599