Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Kogito Runtime Tools to the process-decisions-quarkus example #977

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rafaeltuelho
Copy link

This PR extends the process-decisions-quarkus example adding a new maven profile (runtime-tools) enabling the Kogito Runtime Tools Quarkus Extension which provides Management Console in the DevUI. It also includes a docker-compose file to start the Kogito Data Index Service (with Kafka and ISPN) to support the Management Console Process Instance visualization.

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

12 similar comments
@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Nov 12, 2021

Can one of the admins verify this patch?

@danielezonca
Copy link
Contributor

Ok to test

Copy link
Contributor

@tiagodolphine tiagodolphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafaeltuelho nice work, I just left some comments.
Thanks

process-decisions-quarkus/README.md Show resolved Hide resolved
Comment on lines 12 to 47
kafka.bootstrap.servers=localhost:9092

# Kogito Events config
kogito.events.processinstances.enabled=true
kogito.events.variables.enabled=true
kogito.events.usertasks.enabled=false

mp.messaging.outgoing.kogito-processinstances-events.connector=smallrye-kafka
mp.messaging.outgoing.kogito-processinstances-events.topic=kogito-processinstances-events
mp.messaging.outgoing.kogito-processinstances-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer

mp.messaging.outgoing.kogito-usertaskinstances-events.connector=smallrye-kafka
mp.messaging.outgoing.kogito-usertaskinstances-events.topic=kogito-usertaskinstances-events
mp.messaging.outgoing.kogito-usertaskinstances-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer

mp.messaging.outgoing.kogito-variables-events.connector=smallrye-kafka
mp.messaging.outgoing.kogito-variables-events.topic=kogito-variables-events
mp.messaging.outgoing.kogito-variables-events.value.serializer=org.apache.kafka.common.serialization.StringSerializer

# Data-index service URL
kogito.dataindex.http.url=http://localhost:8180
kogito.dataindex.ws.url=ws://localhost:8180
# ISPN Connection
quarkus.infinispan-client.server-list=localhost:11222
quarkus.infinispan-client.use-auth=false

org.kie.kogito.runtime.tools.quarkus.extension.runtime.dataindex.DataIndexClient/mp-rest/url=http://localhost:8180
# Mocked users and groups for the task inbox screen
quarkus.kogito-runtime-tools.users=jdoe,admin,user
quarkus.kogito-runtime-tools.users.jdoe.groups=admin
quarkus.kogito-runtime-tools.users.admin.groups=admin
quarkus.kogito-runtime-tools.users.user.groups=user

quarkus.test.continuous-testing=disabled
quarkus.devservices.enabled=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to define a quarkus profile and set this profile as an env variable in the pom.xml when executing the maven profile runtime-tools you introduced, in this way, if users just execute the default example, no messaging, kafka etc will be needed in the application.properties file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! That makes sense. I'll do that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagodolphine I think I should use Quarkus default dev profile for these messaging and runtime-tools properties. Because the idea of the new Kogito Runtime Tools ext is to bring kogito services to Quarks DevUI. Thus when starting the app with

mvn quarkus:dev -Pruntime-tools

will pick up these additional messaging props...
What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, ignore my last comment. I decided to put these additional config props into a separate file application-runtime-tools.properties. This way when the user execute the runtime-tools maven profile it will automatically activate a custom quarkus profile named runtime-tools

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great I like this idea to have a different application.properties for the new profile.

So let's wait for the PR.

@kie-ci
Copy link
Contributor

kie-ci commented Nov 17, 2021

The (build) kogito-examples check has failed. Please check the logs.

@domhanak domhanak added the stale This label is for items that are stale with no activity for more than a month label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This label is for items that are stale with no activity for more than a month
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants