-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set OpenShift Serverless Logic productized images to version 1.31.0 #1702
Conversation
@rgdoliveira as peer or discussion, this change should be made in the kogito-images, right? |
@spolti I think this one is correct to be here, because at some point main will be forked (cut-off) on 1.45.x and this commit will be part of it. And in fact branch 1.45.x is what will be used for building OSL 1.31. My understanding is that we should apply in kiegroup/kogito-images repository changes related to legacy branches, like 1.13.x. |
Thanks. |
It is, please merge it. |
OK, just wait for @krisv approval, then I'll merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spolti sorry, I found something missing in this PR.
@bacciotti please in files logic-swf-builder-rhel8-image.yaml
and logic-swf-devmode-rhel8-image.yaml
update the branch to openshift-serverless-1.31-rhel-8
@spolti @rgdoliveira updated. |
@spolti now it is ready to be merged :) |
Many thanks for submitting your Pull Request ❤️!
Please make sure your PR meets the following requirements:
[KOGITO|RHPAM-XYZ] Subject
How to retest this PR or trigger a specific build:
(Re)run Jenkins tests
Please add comment: Jenkins [test|retest] this
Prod tests
Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.