Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OpenShift Serverless Logic productized images to version 1.31.0 #1702

Closed
wants to merge 2 commits into from

Conversation

bacciotti
Copy link
Contributor

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change
How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this

  • Prod tests
    Please add comment: Jenkins (re)run [prod|Prod|PROD]

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@bacciotti bacciotti marked this pull request as draft September 19, 2023 10:53
@bacciotti bacciotti marked this pull request as ready for review September 19, 2023 10:54
@spolti
Copy link
Member

spolti commented Sep 27, 2023

@rgdoliveira as peer or discussion, this change should be made in the kogito-images, right?

@rgdoliveira
Copy link
Contributor

rgdoliveira commented Sep 27, 2023

@rgdoliveira as peer or discussion, this change should be made in the kogito-images, right?

@spolti I think this one is correct to be here, because at some point main will be forked (cut-off) on 1.45.x and this commit will be part of it. And in fact branch 1.45.x is what will be used for building OSL 1.31.

My understanding is that we should apply in kiegroup/kogito-images repository changes related to legacy branches, like 1.13.x.

@spolti
Copy link
Member

spolti commented Sep 27, 2023

Thanks.
Is this ready to be merged?

@rgdoliveira
Copy link
Contributor

Thanks. Is this ready to be merged?

It is, please merge it.

@spolti spolti requested a review from krisv September 27, 2023 18:22
@spolti
Copy link
Member

spolti commented Sep 27, 2023

OK, just wait for @krisv approval, then I'll merge it.

Copy link
Contributor

@rgdoliveira rgdoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spolti sorry, I found something missing in this PR.

@bacciotti please in files logic-swf-builder-rhel8-image.yaml and logic-swf-devmode-rhel8-image.yaml update the branch to openshift-serverless-1.31-rhel-8

@bacciotti
Copy link
Contributor Author

@spolti @rgdoliveira updated.

@rgdoliveira
Copy link
Contributor

@spolti now it is ready to be merged :)

@bacciotti bacciotti closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants