Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.x] NO-ISSUE: set 10.0.x as a tag #1781

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jstastny-cz
Copy link
Contributor

Adjusting manage-kogito-version.py script to allow bumping versions to 10.0.x

The value args.bump_to, when containing 10.0.x, might not be valid for all place where applied - because the value is also used as defaults e.g. for artifacts_version (maven versions), but script offers sufficient override options.

By allowing 10.0.x and adjusting setup-branch job to actually set such value, we don't need any special precautions when building nightlies (like prefixing a tag or what not). Actually those prefixes nightly- were removed some time ago, when we agreed that nightly tag would actually be 10.0.x for 10.0.x branches.

Copy link
Contributor

@rodrigonull rodrigonull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tiagobento tiagobento merged commit d580775 into apache:10.0.x Jul 19, 2024
5 checks passed
@tiagobento
Copy link

@jstastny-cz What about the weekly jobs? They need to change too, no?

jstastny-cz added a commit to jstastny-cz/kogito-images that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants