Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.x] NO-ISSUE: isolate pr checks between branches #1784

Merged

Conversation

jstastny-cz
Copy link
Contributor

A hotfix for kogito-images PR checks not to be executed across branches.

If we keep .ci/jenkins/Jenkinsfile after branching, the pr checks from main would pick them up and execute, which is not desirable.

Given that kogito-images has no GHA PR checks, this is hopefully a quick solution to isolate:

  1. when running setup-branch job, and not on main - rename Jenkinsfile to Jenkinsfile.pr.${branch}
  2. enable PR checks job generation for non-main branches, but differentiate based on Jenkinsfile name between main (Jenkinsfile) and other branches (Jenkinsfile.pr.${branch}).

Since this is against 10.0.x I went ahead and renamed the file not to have to run setup-branch afterwards.

Note: Changes 1 and 2 need to be forward-ported to main.

@tiagobento tiagobento merged commit 6513ba1 into apache:10.0.x Jul 22, 2024
4 checks passed
jstastny-cz added a commit to jstastny-cz/incubator-kie-kogito-images that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants